In Dashboard, in the display of a nodes report, in the display of the log, messages that contain file diffs should be displayed sanely
|Assignee:||Daniel Sauble||% Done:|
|Branch:||Affected Dashboard version:|
A recent change to the agent started pushing the text of file diffs into the report, when a file is modified. This means that we get standard “unified” diff output in the “message” field, where we also get other notices about changes to a file.
In the Log view, the output of the diff on a modified file is rendered as a plain HTML text element, which means it loses all newlines. The diff should be wrapped in %lt;pre> tags or otherwise formatted, so that it doesn’t lose that structure.
#2 Updated by Daniel Pittman over 1 year ago
- Subject changed from Display of diffs should be unformatted to In Dashboard, in the display of a nodes report, in the display of the log, messages that contain file diffs should be displayed sanely
- Description updated (diff)
- Status changed from Unreviewed to Needs Decision
- Assignee changed from Daniel Pittman to Jason McKerr
Jason, can you please make a scheduling decision, then pass this along to the right person. Thanks.
#7 Updated by Daniel Pittman over 1 year ago
Randall Hansen wrote:
I think the primary difficulty will be detecting diffs; after that, design shouldn’t be hard.
Are we happy with a heuristic mechanism, which makes the decision based on the seeming of the content? The diff variants have fairly structured content, allowing us to be fairly confident in that decision.
Do we need to care about more than just unified diffs? (eg: anything other than what we currently generate?)
Are we interested in considering structured presentations for more than just diffs, such as syntax colouring for configuration files, if that is inexpensive?
What is the target version for this change?