The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Feature #10966

Add bios information to facter

Added by Tomas Edwardsson about 3 years ago. Updated over 1 year ago.

Status:Merged - Pending ReleaseStart date:11/19/2011
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:library
Target version:1.7.0
Keywords: Affected Facter version:
Branch:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

Patch and pull request at:

https://github.com/puppetlabs/facter/pull/81

History

#1 Updated by Ken Barber about 3 years ago

  • Category set to library
  • Status changed from Unreviewed to Accepted
  • Target version set to 186

Hi Tomas,

Thanks for this …

Can I suggest we use ‘biosversion’ without an underscore? It fits the current convention.

Also – the pull request is no longer merge-able. Can you please rebase this?

#2 Updated by Anonymous almost 3 years ago

  • Status changed from Accepted to Code Insufficient

The pull request has merge conflicts and unrelated commits in it at the moment; we have asked the author to update that.

#3 Updated by Ken Barber almost 3 years ago

  • Status changed from Code Insufficient to Tests Insufficient

Pull request is here:

https://github.com/puppetlabs/facter/pull/144

We’ll need tests.

#4 Updated by Anonymous over 2 years ago

  • Target version deleted (186)

#5 Updated by Jason Gill over 2 years ago

I’ve written tests and squashed this into a single commit in pull request over at github

https://github.com/puppetlabs/facter/pull/243

#6 Updated by Jason Gill over 2 years ago

  • Assignee set to Ken Barber

#7 Updated by Ken Barber over 2 years ago

  • Status changed from Tests Insufficient to In Topic Branch Pending Review
  • Assignee deleted (Ken Barber)

Thanks heaps Jason – however I’m not actively working on Facter any more, so un-assigning it. Someone in the correct team should review this for you.

#8 Updated by Anonymous about 2 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version set to 2.0.0

#9 Updated by Anonymous over 1 year ago

  • Target version changed from 2.0.0 to 1.7.0

This was actually released in 1.7.0 and merged in commit 1878e9b

Also available in: Atom PDF