Feature #10966
Add bios information to facter
| Status: | Merged - Pending Release | Start date: | 11/19/2011 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | library | |||
| Target version: | 2.0.0 | |||
| Keywords: | Affected Facter version: | |||
| Branch: | ||||
Description
Patch and pull request at:
https://github.com/puppetlabs/facter/pull/81
History
#1
Updated by Ken Barber over 1 year ago
- Category set to library
- Status changed from Unreviewed to Accepted
- Target version set to 186
Hi Tomas,
Thanks for this …
Can I suggest we use ‘biosversion’ without an underscore? It fits the current convention.
Also – the pull request is no longer merge-able. Can you please rebase this?
#2
Updated by Daniel Pittman over 1 year ago
- Status changed from Accepted to Code Insufficient
The pull request has merge conflicts and unrelated commits in it at the moment; we have asked the author to update that.
#3
Updated by Ken Barber over 1 year ago
- Status changed from Code Insufficient to Tests Insufficient
#4
Updated by Daniel Pittman over 1 year ago
- Target version deleted (
186)
#5
Updated by Jason Gill about 1 year ago
I’ve written tests and squashed this into a single commit in pull request over at github
#6
Updated by Jason Gill about 1 year ago
- Assignee set to Ken Barber
#7
Updated by Ken Barber about 1 year ago
- Status changed from Tests Insufficient to In Topic Branch Pending Review
- Assignee deleted (
Ken Barber)
Thanks heaps Jason – however I’m not actively working on Facter any more, so un-assigning it. Someone in the correct team should review this for you.
#8
Updated by Daniel Pittman 10 months ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
- Target version set to 2.0.0