Bug #11115
Puppet specs test do not run under spec 2.7.x
| Status: | Closed | Start date: | 12/01/2011 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | 12/01/2011 | |
| Assignee: | - | % Done: | 100% | |
| Category: | testing | Estimated time: | 1.00 hour | |
| Target version: | 3.0.0 | |||
| Affected Puppet version: | development | Branch: | https://github.com/puppetlabs/puppet/pull/240 | |
| Keywords: | ||||
Description
Currently Puppet spec tests do not run under spec 2.7.x. When using spec 2.7.1 I get the following errors:
/usr/local/rvm/rubies/ruby-1.8.7-p352/lib/ruby/1.8/rdoc/dot/dot.rb:28: warning: already initialized constant NODE_OPTS
/usr/local/rvm/rubies/ruby-1.8.7-p352/lib/ruby/1.8/rdoc/dot/dot.rb:46: warning: already initialized constant EDGE_OPTS
/usr/local/rvm/rubies/ruby-1.8.7-p352/lib/ruby/1.8/rdoc/dot/dot.rb:76: warning: already initialized constant GRAPH_OPTS
/usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/configuration.rb:470:in `assert_no_example_groups_defined': RSpec's mock_framework configuration option must be configured before any example groups are defined, but you have already defined a group. (RSpec::Core::Configuration::MustBeConfiguredBeforeExampleGroupsError)
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/configuration.rb:168:in `mock_framework='
from /root/puppet/spec/unit/network/../../spec_helper.rb:35
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core.rb:71:in `configure'
from /root/puppet/spec/unit/network/../../spec_helper.rb:31
from /usr/local/rvm/rubies/ruby-1.8.7-p352/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require'
from /usr/local/rvm/rubies/ruby-1.8.7-p352/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:240:in `require'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:223:in `load_dependency'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:640:in `new_constants_in'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:223:in `load_dependency'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:240:in `require'
from /root/puppet/spec/unit/network/resolver_spec.rb:2
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:234:in `load'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:234:in `load'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:223:in `load_dependency'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:640:in `new_constants_in'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:223:in `load_dependency'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:234:in `load'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/configuration.rb:459:in `load_spec_files'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/configuration.rb:459:in `map'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/configuration.rb:459:in `load_spec_files'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/command_line.rb:18:in `run'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/runner.rb:80:in `run_in_process'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/runner.rb:69:in `run'
from /usr/local/rvm/gems/ruby-1.8.7-p352/gems/rspec-core-2.7.1/lib/rspec/core/runner.rb:10:in `autorun'
from /usr/local/rvm/gems/ruby-1.8.7-p352/bin/rspec:19
History
#1
Updated by Kelsey Hightower over 1 year ago
- Status changed from Accepted to In Topic Branch Pending Review
- Branch set to https://github.com/puppetlabs/puppet/pull/240
#2
Updated by Kelsey Hightower over 1 year ago
- % Done changed from 50 to 100
#3
Updated by Jacob Helwig over 1 year ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
- Assignee deleted (
Kelsey Hightower) - Target version set to 3.x
- Affected Puppet version set to development
This has been merged into master in commit:17459b538bf8cdb1ed1839e403f1763664f175f6
(#11115) Support spec tests under rspec 2.7.x
Without this patch, the puppet spec tests do not run under rspec 2.7.x.
This patch fixes this issue by using a proper require expression to
include the `spec_helper` module in `spec/unit/network/resolver_spec.rb`
This patch changes a single line in `spec/unit/network/resolver_spec.rb`
as the other tests already require the `spec_helper` the *right* way.
#4
Updated by Daniel Pittman about 1 year ago
- Target version changed from 3.x to 3.0.0
#5
Updated by Matthaus Owens 9 months ago
- Status changed from Merged - Pending Release to Closed
Released in Puppet 3.0.0rc1