Bug #1116
Checksums are changing on every run causing unnecessary dependency runs and noise
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Blake Barnett |
% Done: | 0% |
|
| Category: | - | |||
| Target version: | 0.24.3 | |||
| Affected Puppet version: | 0.25.4 | Branch: | ||
| Keywords: | ||||
| Votes: | 0 |
Description
On every run I’m seeing checksums changing from {time} to {mtime}, this is causing dependencies to get refreshed, when they shouldn’t be. For example, here are the first ten or so lines that I am receiving in logcheck emails for my puppet runs (there are a lot more):
Mar 5 19:03:56 kakapo puppetdr8098: (/File[/var/lib/puppet/lib]/checksum) checksum changed '{time}Mon Oct 15 13:00:18 -0700 2007' to '{mtime}Mon Oct 15
13:00:18 -0700 2007'
Mar 5 19:03:57 kakapo puppetdr8098: (/File[/var/lib/puppet/lib/facter]/checksum) checksum changed '{time}Mon Mar 03 20:50:51 -0800 2008' to '{mtime}Mon Mar
03 20:50:51 -0800 2008'
Mar 5 19:03:58 kakapo puppetdr8098: (/File[/var/lib/puppet/lib/puppet]/checksum) checksum changed '{time}Fri Oct 12 09:34:54 -0700 2007' to '{mtime}Fri Oct
12 09:34:54 -0700 2007'
Mar 5 19:03:58 kakapo puppetdr8098: (/File[/var/lib/puppet/lib/puppet/parser]/checksum) checksum changed '{time}Fri Oct 12 09:34:57 -0700 2007' to '{mtime}Fri Oct 12 09:34:57 -0700 2007'
Mar 5 19:03:58 kakapo puppetdr8098: (/File[/var/lib/puppet/lib/puppet/parser/functions]/checksum) checksum changed '{time}Fri Oct 12 09:45:14 -0700 2007' to '{mtime}Fri Oct 12 09:45:14 -0700 2007'
Mar 5 19:04:25 kakapo puppetdr8098: (//Node[kakapo]/debian_base/File[/usr/local/bin]/checksum) checksum changed '{time}Thu May 10 17:39:44 -0700 2007' to '{mtime}Thu May 10 17:39:44 -0700 2007'
Mar 5 19:04:30 kakapo puppetdr8098: (//assert_lsbdistcodename/Exec[/bin/true # require_lsbdistcodename]/returns) executed successfully
Mar 5 19:04:34 kakapo puppetdr8098: (//Node[kakapo]/munin::client/munin::client::debian/Service[munin-node]) Triggering 'refresh' from 2 dependencies
Mar 5 19:04:34 kakapo puppetdr8098: (//Node[kakapo]/munin::client/munin::plugins::base/File[/etc/munin/plugin-conf.d]/checksum) checksum changed '{time}Fri
Feb 15 06:26:27 -0800 2008' to '{mtime}Fri Feb 15 06:26:27 -0800 2008'
Mar 5 19:04:34 kakapo puppetdr8098: (//Node[kakapo]/munin::client/munin::plugins::base/File[/etc/munin/plugins]/checksum) checksum changed '{time}Fri Feb
15 06:26:18 -0800 2008' to '{mtime}Fri Feb 15 06:26:18 -0800 2008'
Mar 5 19:04:36 kakapo puppetdr8098: (//File[/var/local]/checksum) checksum changed '{time}Thu May 10 19:18:42 -0700 2007' to '{mtime}Thu May 10 19:18:42
-0700 2007'
Mar 5 19:04:36 kakapo puppetdr8098: (//File[/var/local/puppet]/checksum) checksum changed '{time}Thu May 10 19:18:42 -0700 2007' to '{mtime}Thu May 10
19:18:42 -0700 2007'
Mar 5 19:04:36 kakapo puppetdr8098: (//File[/var/local/puppet/munin-nodes]/checksum) checksum changed '{time}Thu May 10 19:18:42 -0700 2007' to '{mtime}Thu
May 10 19:18:42 -0700 2007'
Mar 5 19:04:39 kakapo puppetdr8098: (//Node[kakapo]/debian_base/logcheck/File[/etc/logcheck]/checksum) checksum changed '{time}Fri Aug 24 22:13:18 -0700
2007' to '{mtime}Fri Aug 24 22:13:18 -0700 2007'
Mar 5 19:04:40 kakapo puppetdr8098: (//Node[kakapo]/debian_base/logcheck/File[/etc/logcheck/ignore.d.server]/checksum) checksum changed '{time}Wed Mar 05
11:08:21 -0800 2008' to '{mtime}Wed Mar 05 11:08:21 -0800 2008'
Mar 5 19:04:42 kakapo puppetdr8098: (//Node[kakapo]/debian_base/logcheck/File[/etc/logcheck/violations.ignore.d]/checksum) checksum changed '{time}Sun Feb
10 09:32:36 -0800 2008' to '{mtime}Sun Feb 10 09:32:36 -0800 2008'
Mar 5 19:04:44 kakapo puppetdr8098: (//Node[kakapo]/debian_base/logcheck/File[/etc/logcheck/cracking.ignore.d]/checksum) checksum changed '{time}Fri Aug 24
22:13:16 -0700 2007' to '{mtime}Fri Aug 24 22:13:16 -0700 2007'
Mar 5 19:04:46 kakapo puppetdr8098: (//File[/usr/local/share/munin-plugins]/checksum) checksum changed '{time}Thu Oct 11 09:29:49 -0700 2007' to
'{mtime}Thu Oct 11 09:29:49 -0700 2007'
Mar 5 19:04:47 kakapo puppetdr8098: (//File[/var/lib/puppet/modules]/checksum) checksum changed '{time}Mon Mar 03 19:45:08 -0800 2008' to '{mtime}Mon Mar
03 19:45:08 -0800 2008'
Mar 5 19:04:47 kakapo puppetdr8098: (//Modules_dir[nagios]/File[/var/lib/puppet/modules/nagios]/checksum) checksum changed '{time}Mon Mar 03 19:45:08 -0800
History
Updated by micah - about 4 years ago
Sorry, trac needs me to use quoting to get those lines to be readable, so here they are again:
Mar 5 19:03:56 kakapo puppetdr8098: (/File[/var/lib/puppet/lib]/checksum) checksum changed '{time}Mon Oct 15 13:00:18 -0700 2007' to '{mtime}Mon Oct 15
13:00:18 -0700 2007'
Mar 5 19:03:57 kakapo puppetdr8098: (/File[/var/lib/puppet/lib/facter]/checksum) checksum changed '{time}Mon Mar 03 20:50:51 -0800 2008' to '{mtime}Mon Mar
03 20:50:51 -0800 2008'
Mar 5 19:03:58 kakapo puppetdr8098: (/File[/var/lib/puppet/lib/puppet]/checksum) checksum changed '{time}Fri Oct 12 09:34:54 -0700 2007' to '{mtime}Fri Oct
12 09:34:54 -0700 2007'
Mar 5 19:03:58 kakapo puppetdr8098: (/File[/var/lib/puppet/lib/puppet/parser]/checksum) checksum changed '{time}Fri Oct 12 09:34:57 -0700 2007' to
'{mtime}Fri Oct 12 09:34:57 -0700 2007'
Mar 5 19:03:58 kakapo puppetdr8098: (/File[/var/lib/puppet/lib/puppet/parser/functions]/checksum) checksum changed '{time}Fri Oct 12 09:45:14 -0700 2007'
to '{mtime}Fri Oct 12 09:45:14 -0700 2007'
Mar 5 19:04:25 kakapo puppetdr8098: (//Node[kakapo]/debian_base/File[/usr/local/bin]/checksum) checksum changed '{time}Thu May 10 17:39:44 -0700 2007' to
'{mtime}Thu May 10 17:39:44 -0700 2007'
Mar 5 19:04:30 kakapo puppetdr8098: (//assert_lsbdistcodename/Exec[/bin/true # require_lsbdistcodename]/returns) executed successfully
Mar 5 19:04:34 kakapo puppetdr8098: (//Node[kakapo]/munin::client/munin::client::debian/Service[munin-node]) Triggering 'refresh' from 2 dependencies
Mar 5 19:04:34 kakapo puppetdr8098: (//Node[kakapo]/munin::client/munin::plugins::base/File[/etc/munin/plugin-conf.d]/checksum) checksum changed '{time}Fri
Feb 15 06:26:27 -0800 2008' to '{mtime}Fri Feb 15 06:26:27 -0800 2008'
Mar 5 19:04:34 kakapo puppetdr8098: (//Node[kakapo]/munin::client/munin::plugins::base/File[/etc/munin/plugins]/checksum) checksum changed '{time}Fri Feb
15 06:26:18 -0800 2008' to '{mtime}Fri Feb 15 06:26:18 -0800 2008'
Mar 5 19:04:36 kakapo puppetdr8098: (//File[/var/local]/checksum) checksum changed '{time}Thu May 10 19:18:42 -0700 2007' to '{mtime}Thu May 10 19:18:42
-0700 2007'
Mar 5 19:04:36 kakapo puppetdr8098: (//File[/var/local/puppet]/checksum) checksum changed '{time}Thu May 10 19:18:42 -0700 2007' to '{mtime}Thu May 10
19:18:42 -0700 2007'
Mar 5 19:04:36 kakapo puppetdr8098: (//File[/var/local/puppet/munin-nodes]/checksum) checksum changed '{time}Thu May 10 19:18:42 -0700 2007' to '{mtime}Thu
May 10 19:18:42 -0700 2007'
Mar 5 19:04:39 kakapo puppetdr8098: (//Node[kakapo]/debian_base/logcheck/File[/etc/logcheck]/checksum) checksum changed '{time}Fri Aug 24 22:13:18 -0700
2007' to '{mtime}Fri Aug 24 22:13:18 -0700 2007'
Mar 5 19:04:40 kakapo puppetdr8098: (//Node[kakapo]/debian_base/logcheck/File[/etc/logcheck/ignore.d.server]/checksum) checksum changed '{time}Wed Mar 05
11:08:21 -0800 2008' to '{mtime}Wed Mar 05 11:08:21 -0800 2008'
Mar 5 19:04:42 kakapo puppetdr8098: (//Node[kakapo]/debian_base/logcheck/File[/etc/logcheck/violations.ignore.d]/checksum) checksum changed '{time}Sun Feb
10 09:32:36 -0800 2008' to '{mtime}Sun Feb 10 09:32:36 -0800 2008'
Mar 5 19:04:44 kakapo puppetdr8098: (//Node[kakapo]/debian_base/logcheck/File[/etc/logcheck/cracking.ignore.d]/checksum) checksum changed '{time}Fri Aug 24
22:13:16 -0700 2007' to '{mtime}Fri Aug 24 22:13:16 -0700 2007'
Mar 5 19:04:46 kakapo puppetdr8098: (//File[/usr/local/share/munin-plugins]/checksum) checksum changed '{time}Thu Oct 11 09:29:49 -0700 2007' to
'{mtime}Thu Oct 11 09:29:49 -0700 2007'
Mar 5 19:04:47 kakapo puppetdr8098: (//File[/var/lib/puppet/modules]/checksum) checksum changed '{time}Mon Mar 03 19:45:08 -0800 2008' to '{mtime}Mon Mar
03 19:45:08 -0800 2008'
Mar 5 19:04:47 kakapo puppetdr8098: (//Modules_dir[nagios]/File[/var/lib/puppet/modules/nagios]/checksum) checksum changed '{time}Mon Mar 03 19:45:08 -0800
Updated by Blake Barnett about 4 years ago
commit 0265a69 in my repo: [http://github.com/shadoi/puppet/commit/0265a693bd14cca3b014d611f38d20bf5ac65609]
Updated by Luke Kanies about 4 years ago
- Status changed from 1 to Closed
- 7 set to fixed
Pushed the new branch.
Updated by micah - about 4 years ago
I’m going crazy.
Things worked fine after I installed this fix, I wasn’t getting these messages… but I started getting them again just today. I looked at line 69 of lib/puppet/type/file/checksum.rb and I’ve got the changes that are in 0265a69 referenced here. Yesterday I had zero of these in my logs, today I have 70.
Updated by micah - about 4 years ago
Ok, there is a difference here, thanks to fujin to pointing it out, the changes I am seeing are {mtime}–>{mtime} now, instead of {time}–>{mtime}, slight difference, but I am guessing that there is another place that this needs to be changed?
Updated by Blake Barnett about 4 years ago
Are the two mtime’s identical? Are the files/directories actually changing? I’m not seeing any of the same behavior as before.
Updated by micah - about 4 years ago
No, the files/directories aren’t actually changing.
I opened #1127 about this issue because its different than this one. The {time}–>{mtime} issue has been solved.