Bug #11627

Don't show diff of last_run_summary.yaml

Added by Josh Cooper 5 months ago. Updated 2 months ago.

Status:Accepted Start date:12/29/2011
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:-
Target version:2.7.x
Affected Puppet version:development Branch:
Keywords:
Votes: 3

Description

When show_diff is enabled, puppet displays a diff of last_run_summary.yaml, which is always different since it includes time stamps:

$ puppet agent --test --server sirrus.local --certname mac8
info: Loading facts in foo
info: Loading facts in foo
info: Caching catalog for mac8
info: Applying configuration version '1325186688'
notice: Finished catalog run in 0.02 seconds
notice: /File[/Users/josh/.puppet/var/state/last_run_summary.yaml]/content: 
--- /Users/josh/.puppet/var/state/last_run_summary.yaml 2011-12-29 12:00:24.000000000 -0800
+++ /var/folders/9z/9zXImgchH8CZJh6SgiqS2U+++TM/-Tmp-/puppet-file20111229-93222-ds8l3c-0    2011-12-29 13:26:02.000000000 -0800
@@ -1,9 +1,9 @@
 --- 
   time: 
-    last_run: 1325188824
-    config_retrieval: 1.0739951133728
-    total: 1.0741571133728
-    filebucket: 0.000162
+    last_run: 1325193962
+    config_retrieval: 0.268381118774414
+    total: 0.268589118774414
+    filebucket: 0.000208
   resources: 
     failed: 0
     changed: 0

This change was introduced in #7106 in commit:b28cac8bea0eef58791c9e7e0749e5762f6e59d1 because we’re now using a file resource to manage the file.

We probably want to skip diffs if catalog.host_config is false

History

#1
Updated by Daniel Pittman 5 months ago

  • Status changed from Unreviewed to Needs More Information
  • Assignee set to Josh Cooper

Josh, what else is this report waiting on before it can be accepted?

#2
Updated by Josh Cooper 5 months ago

  • Status changed from Needs More Information to Accepted
  • Assignee deleted (Josh Cooper)

Also available in: Atom PDF