Bug #11695

factor comments

Added by shubhra sinha varma 4 months ago. Updated 3 months ago.

Status:In Topic Branch Pending Review Start date:01/03/2012
Priority:Normal Due date:
Assignee:shubhra sinha varma % Done:

0%
Category:-
Target version:1.6.x
Keywords: Affected Facter version:
Branch:https://github.com/puppetlabs/facter/pull/157
Votes: 0

Description

Add/update comments in the factor/lib. Relates to closed ticket #5394.

History

#1
Updated by shubhra sinha varma 4 months ago

Added/updated factor comments in factor/lib. Working branch is 11695factordoc.

#2
Updated by Ken Barber 4 months ago

  • Status changed from In Topic Branch Pending Review to Needs More Information

Hi,

Was there a pull request for this somewhere? Can you paste it in the ticket? Also – what version was this targeted at?

ken.

#3
Updated by shubhra sinha varma 4 months ago

  • Assignee set to shubhra sinha varma
  • Target version set to 1.6.x

Opened a Pull request for additional comments in facter/lib in the ssvarma:11695factordoc area. Had previously mistakenly associated this work with the puppet module documentation hence had put ticket #6349 instead of the new ticket #11695 for the commits.

#4
Updated by Daniel Pittman 4 months ago

  • Status changed from Needs More Information to Code Insufficient

I have reviewed the content, and a bunch of the documentation needs work. Comments were sent through the GitHub interface as normal.

#5
Updated by Dominic Cleal 4 months ago

  • Branch set to https://github.com/puppetlabs/facter/pull/145

#6
Updated by shubhra sinha varma 4 months ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review

#7
Updated by shubhra sinha varma 4 months ago

All updated and cleaned. updated the pull request.

#8
Updated by Ken Barber 3 months ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient

See comments in the pull request.

#9
Updated by Adrien Thebo 3 months ago

  • Branch changed from https://github.com/puppetlabs/facter/pull/145 to https://github.com/puppetlabs/facter/pull/157

#10
Updated by shubhra sinha varma 3 months ago

all updates and additions on my pull at:

https://github.com/puppetlabs/facter/pull/157/files

#11
Updated by shubhra sinha varma 3 months ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review
  • Branch deleted (https://github.com/puppetlabs/facter/pull/157)

All commenting done for current facts.

#12
Updated by shubhra sinha varma 3 months ago

  • Branch set to https://github.com/puppetlabs/facter/pull/157

Also available in: Atom PDF