Bug #12339: Formatted the output for `puppet module search` - Puppet - Puppet Labs

Bug #12339

Formatted the output for `puppet module search`

Added by Pieter van de Bruggen over 1 year ago. Updated 8 months ago.

Status:

Closed

Start date:

01/31/2012

Priority:

Normal

Due date:

Assignee:

% Done:

Category:

module tool

Target version:

Affected Puppet version:

Branch:

Keywords:

geordi v1

Description

As per earlier discussions:

Size: Ideally, we would have some intelligence around that (e.g. https://github.com/wycats/thor/blob/master/lib/thor/shell/basic.rb#L274), falling back to 80 characters when we can't determine the width.

Columns:
The NAME column should be the width of the longest name, to a minimum of 12 characters.
The AUTHOR column should likewise be the width of the longest name (+ the '@' sigil), to a minimum of 12 characters.
The KEYWORDS column should be 1/3 of the remaining space. If all keywords do not fit in this space, "less important" keywords should removed until they do fit. Keywords that match the search pattern should not be removed -- if this still will not fit in the available space, the column should be expanded to fit.
The DESCRIPTION column should take up the remaining space, eliding any content that doesn't fit.

History

#1 Updated by Pieter van de Bruggen over 1 year ago

Code available for review at: https://github.com/pvande/puppet/tree/tickets/master/12339-module-search-formatting

#2 Updated by Daniel Pittman over 1 year ago

Pieter van de Bruggen wrote:

Code available for review at: https://github.com/pvande/puppet/tree/tickets/master/12339-module-search-formatting

I added comments to the code; feel free to come discuss this with me in person if you prefer.

#3 Updated by Pieter van de Bruggen over 1 year ago

Pull request (for refactored code) sent: https://github.com/puppetlabs/puppet/pull/442

#4 Updated by Pieter van de Bruggen over 1 year ago

The pull request has been updated with some additional documentation and an explicit self. in the method declaration.

#5 Updated by Daniel Pittman over 1 year ago

Status changed from Accepted to Code Insufficient

One last, licensing related update needed to the pull request and this can totally merge.

#6 Updated by Pieter van de Bruggen over 1 year ago

Status changed from Code Insufficient to In Topic Branch Pending Review

Attribution: success!

#7 Updated by Daniel Pittman over 1 year ago

Pieter van de Bruggen wrote:

Attribution: success!

Ready to merge, once the build stops being broken. Thanks.

#8 Updated by Daniel Pittman over 1 year ago

Status changed from In Topic Branch Pending Review to Merged - Pending Release
Assignee deleted (~~Pieter van de Bruggen~~)
Target version changed from 2.7.x to 2.7.11