The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com
Don't block indefinitely in WaitForSingleObject
|Assignee:||Josh Cooper||% Done:|
|Affected Puppet version:||Branch:||https://github.com/puppetlabs/puppet/pull/556|
Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com
This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.
When creating a child process on Windows, we’re calling the WaitForSingleObject with an INFINITE timeout, which means ruby can’t be interrupted, e.g. Ctrl-C, until the child process exits.
#3 Updated by Anonymous almost 3 years ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
I have merged the change. I half expected it to sleep for some time – a second, up to maybe five – in the Windows call, and not really at all on the Ruby side, which would allow signals to be handled without too much delay, but that implementation looks pretty reasonable, and is certainly safe enough to put into the RC.
#4 Updated by Moses Mendoza almost 3 years ago
- Status changed from Merged - Pending Release to Closed
released in 2.7.12 http://projects.puppetlabs.com/projects/puppet/wiki/Release_Notes#2.7.12