The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

This issue tracker is now in read-only archive mode and automatic ticket export has been disabled. Redmine users will need to create a new JIRA account to file tickets using https://tickets.puppetlabs.com. See the following page for information on filing tickets with JIRA:

Bug #12914

Don't block indefinitely in WaitForSingleObject

Added by Josh Cooper over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:03/01/2012
Priority:NormalDue date:
Assignee:Josh Cooper% Done:

0%

Category:windows
Target version:2.7.12
Affected Puppet version: Branch:https://github.com/puppetlabs/puppet/pull/556
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com


Description

When creating a child process on Windows, we’re calling the WaitForSingleObject with an INFINITE timeout, which means ruby can’t be interrupted, e.g. Ctrl-C, until the child process exits.

History

#1 Updated by Josh Cooper over 3 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to https://github.com/puppetlabs/puppet/pull/555

#2 Updated by Josh Cooper over 3 years ago

  • Branch changed from https://github.com/puppetlabs/puppet/pull/555 to https://github.com/puppetlabs/puppet/pull/556

#3 Updated by Anonymous over 3 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

I have merged the change. I half expected it to sleep for some time – a second, up to maybe five – in the Windows call, and not really at all on the Ruby side, which would allow signals to be handled without too much delay, but that implementation looks pretty reasonable, and is certainly safe enough to put into the RC.

#4 Updated by Moses Mendoza over 3 years ago

  • Status changed from Merged - Pending Release to Closed

#5 Updated by Anonymous over 3 years ago

  • Target version changed from 2.7.x to 2.7.12

Also available in: Atom PDF