Don't block indefinitely in WaitForSingleObject
|Assignee:||Josh Cooper||% Done:|
|Affected Puppet version:||Branch:||https://github.com/puppetlabs/puppet/pull/556|
When creating a child process on Windows, we’re calling the WaitForSingleObject with an INFINITE timeout, which means ruby can’t be interrupted, e.g. Ctrl-C, until the child process exits.
#3 Updated by Daniel Pittman almost 2 years ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
I have merged the change. I half expected it to sleep for some time – a second, up to maybe five – in the Windows call, and not really at all on the Ruby side, which would allow signals to be handled without too much delay, but that implementation looks pretty reasonable, and is certainly safe enough to put into the RC.
#4 Updated by Moses Mendoza over 1 year ago
- Status changed from Merged - Pending Release to Closed
released in 2.7.12 http://projects.puppetlabs.com/projects/puppet/wiki/Release_Notes#2.7.12