Feature #1368

Added genconfig option for redhat scripts and more.

Added by Naoya Nakazawa over 3 years ago. Updated over 3 years ago.

Status:Closed Start date:06/16/2008
Priority:Low Due date:
Assignee:David Lutterkort % Done:

0%
Category:Red Hat
Target version:0.24.5
Affected Puppet version:0.24.4 Branch:
Keywords:redhat, init
Votes: 0

Description

Hi, I added configuration for redhat scripts.

  • Added genconfig option for puppetmaster, puppet init.d script
  • Deleted “—port” option of puppetd init.d script nad sysconfig

I added thoese patch files.

puppet-conf-redhat-client-init.patch (669 Bytes) Naoya Nakazawa, 06/19/2008 08:26 am

puppet-conf-redhat-server-init.patch (611 Bytes) Naoya Nakazawa, 06/19/2008 08:26 am

History

#1
Updated by Redmine Admin over 3 years ago

  • Status changed from Unreviewed to Needs Decision
  • Assignee set to David Lutterkort

Lutter?

#2
Updated by Redmine Admin over 3 years ago

  • Category set to Red Hat
  • Keywords set to redhat, init

#3
Updated by David Lutterkort over 3 years ago

  • Status changed from Needs Decision to Needs More Information

I have no objection to adding a ‘genconfig’ option to the init script.

I don’t think that removing PUPPET_PORT achieves much (yes, it’s redundant, but I don’t want to cause trouble for users that set the port this way for very little gain)

Also, the change in line 24 for server.init is not needed – PUPPETMASTER_OPTS has been set to the empty string on the line before, so no need to append PUPPETMASTER_MANIFEST to it.

Can you revise the patches to just ad the ‘genconfig’ option and nothing else ?

#4
Updated by Naoya Nakazawa over 3 years ago

Hi, lutter.

Thank you for your comment.

lutter wrote:

I have no objection to adding a ‘genconfig’ option to the init script.

I think ‘genconfig’ option is very useful for me. Because I see the configuration when I edited the sysconfig files.

I don’t think that removing PUPPET_PORT achieves much (yes, it’s redundant, but I don’t want to cause trouble for users that set the port this way for very little gain)

I installed puppet 0.24.4, and I uncommented PUPPET_PORT option, puppetd error ‘unknown option —port’. I was confused a little. So I think that “# If you wish to specify the port to connect to do so here” comment is amusing.

Also, the change in line 24 for server.init is not needed – PUPPETMASTER_OPTS has been set to the empty string on the line before, so no need to append PUPPETMASTER_MANIFEST to it.

I understand that the change in line 24 for serevr.init is not needed.

Can you revise the patches to just ad the ‘genconfig’ option and nothing else ?

I just added the ‘genconfig’ option for server.init and client init.

Thank you.

#5
Updated by Naoya Nakazawa over 3 years ago

  • File deleted (puppet-conf-redhat-client-init.patch)

#6
Updated by Naoya Nakazawa over 3 years ago

  • File deleted (puppet-conf-redhat-client-sysconfig.patch)

#7
Updated by Naoya Nakazawa over 3 years ago

  • File deleted (puppet-conf-redhat-server-init.patch)

#8
Updated by Naoya Nakazawa over 3 years ago

Hi, Lutter.

I add ‘genonfig’ option for init script patch.

#9
Updated by James Turnbull over 3 years ago

  • Status changed from Needs More Information to Needs Decision
  • Target version set to 0.24.5

If you’re happy with the new patches I’ll push them.

#10
Updated by James Turnbull over 3 years ago

lutter – ping!

#11
Updated by David Lutterkort over 3 years ago

jamtur01 wrote:

If you’re happy with the new patches I’ll push them.

Yes, this looks good.

#12
Updated by James Turnbull over 3 years ago

  • Status changed from Needs Decision to Closed

Pushed in commit:9eb9affe11b4dbe69c7cd55aff28f39dffde27e8 in branch 0.24.x

Also available in: Atom PDF