Bug #13867

puppet dashboard node:parameters and nodegroup:parameters does not check to see if a parameter with the same name is already set

Added by Patrick Buckley about 1 year ago. Updated 5 months ago.

Status:Merged - Pending ReleaseStart date:04/10/2012
Priority:NormalDue date:
Assignee:Aaron Stone% Done:

0%

Category:-
Target version:1.2.x
Keywords: Affected URL:https://github.com/puppetlabs/puppet-dashboard/pull/166
Branch: Affected Dashboard version:1.2.8

Description

the new rake task for the puppet dashboard node:parameters and nodegroup:parameters does not check to see if a parameter with the same name is already set and allows you to create duplicate key/value pairs with the same key but different values

History

#1 Updated by Patrick Buckley about 1 year ago

  • Affected Dashboard version set to 1.2.7

#2 Updated by Patrick Buckley about 1 year ago

*************************** 218. row *************************** id: 483 key: env_id value: 2 parameterable_id: 274 parameterable_type: Node created_at: 2012-04-10 23:08:47 updated_at: 2012-04-10 23:08:47 *************************** 219. row *************************** id: 486 key: env_id value: 2 parameterable_id: 274 parameterable_type: Node created_at: 2012-04-10 23:32:10 updated_at: 2012-04-10 23:32:10

#3 Updated by Joshua Lifton about 1 year ago

  • Status changed from Unreviewed to Investigating
  • Assignee set to Joshua Lifton
  • Target version set to 1.2.x

#4 Updated by Owen Mehegan about 1 year ago

Is there any update/progress on this bug? Is there anything else we could provide to help with a fix?

#5 Updated by Joshua Lifton about 1 year ago

Which version of Dashboard are you running? The most recent version of the relevant code appears to properly check if the parameters already exist. What are the md5sums for the following files in your setup:

  • $INSTALL_DIR/puppet-dashboard/lib/tasks/classesgroups.rake
  • $INSTALL_DIR/puppet-dashboard/lib/tasks/node.rake

where $INSTALL_DIR is likely to be something like /opt/puppet/share/. The sums I’m seeing are:

  • 2548f1545db99f4b93d5da162f23ccd5
  • cf2fd7c1a80c973dd7798e255630a653

respectively.

#6 Updated by Patrick Buckley about 1 year ago

root@:/usr/share/puppet-dashboard# md5sum lib/tasks/classesgroups.rake 2548f1545db99f4b93d5da162f23ccd5 lib/tasks/classesgroups.rake

root@:/usr/share/puppet-dashboard# md5sum lib/tasks/node.rake cf2fd7c1a80c973dd7798e255630a653 lib/tasks/node.rake

1.2.8 still appears to have this issue

#7 Updated by Patrick Buckley about 1 year ago

  • Affected Dashboard version changed from 1.2.7 to 1.2.8rc2

#8 Updated by Patrick Buckley about 1 year ago

Another option is if you can provide a mechanism for me to query the value of a parameter in the dashboard by host, key and value I can implement the check on my side.

#9 Updated by Patrick Buckley 12 months ago

  • Affected Dashboard version changed from 1.2.8rc2 to 1.2.8

#10 Updated by Aaron Stone 8 months ago

Please also add node:parameters to the Rake API documentation: http://docs.puppetlabs.com/dashboard/manual/1.2/rake_api.html

#11 Updated by Aaron Stone 5 months ago

  • Status changed from Investigating to In Topic Branch Pending Review
  • Affected URL set to https://github.com/puppetlabs/puppet-dashboard/pull/166

Fixed in GitHub PR https://github.com/puppetlabs/puppet-dashboard/pull/166, please review for merge to next Dashboard release!

#12 Updated by Aaron Stone 5 months ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

#13 Updated by Aaron Stone 5 months ago

  • Assignee changed from Joshua Lifton to Aaron Stone

Also available in: Atom PDF