Bug #14387: Puppet's Module face should send along an appropriate UA string - Puppet - Puppet Labs

Bug #14387

Puppet's Module face should send along an appropriate UA string

Added by Pieter van de Bruggen about 1 year ago. Updated 2 months ago.

Status:

Closed

Start date:

05/09/2012

Priority:

Normal

Due date:

Assignee:

Andrew Parker

% Done:

Category:

Target version:

3.0.0

Affected Puppet version:

Branch:

https://github.com/puppetlabs/puppet/pull/762

Keywords:

customer

Description

At present, the Module face makes its HTTP requests anonymously, which makes it somewhat more difficult to do analysis on adoption stats.

Ideally, I’d like to see a user agent string like:

PMT/1.0.2 (core) Puppet/3.0.0 (Ubuntu 10.04)

PMT/1.0.2 (module) Puppet/3.0.0 (Ubuntu 10.04; PE 3.5.0)

History

#1 Updated by Daniel Pittman about 1 year ago

Status changed from Unreviewed to Accepted

It would be nice, but is not essential, to implement this.

#2 Updated by Andrew Parker about 1 year ago

Assignee set to Andrew Parker

#3 Updated by Andrew Parker about 1 year ago

Talked with Pieter to get some clarification.

The version string should be along the lines of: PMT/$face_version ($face_installation_location) Puppet/$puppet_version ($os_description $pe_version) Ruby/$ruby_version

$face_installation_location can always be “core” until we can tell the difference between a core module and an installed module.

Since $puppet_version would include information that it is Puppet Enterprise (and what version of PE), then the $pe_version probably isn’t needed.