The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #15090

emacs mode doesn't match style guide when formatting fat comma arrows

Added by micah - over 2 years ago. Updated 9 months ago.

Status:InvestigatingStart date:06/18/2012
Priority:NormalDue date:
Assignee:James Turnbull% Done:

0%

Category:ext
Target version:-
Affected Puppet version: Branch:
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This ticket is now tracked at: https://tickets.puppetlabs.com/browse/PUP-1889


Description

according to section 9.2 of the style-guide (http://docs.puppetlabs.com/guides/style_guide#arrow-alignment), “All of the fat comma arrows (=>) in a resource‚Äôs attribute/value list should be aligned. The arrows should be placed one space ahead of the longest attribute name.”

The emacs mode does not do this, for example:


  file { '/etc/rcS.d/S02cleanutmp':
    ensure => absent,
    content => '#!/bin/sh\n rm /var/run/utmp\n';
  }

the above was formatted with the emacs mode, but will receive complaints from puppet-lint due to the => on the ensure parameter line not matching up with the content parameter.

History

#1 Updated by eric sorenson over 2 years ago

  • Status changed from Unreviewed to Investigating
  • Assignee set to James Turnbull

James, git blame ext/emacs/puppet-mode.el threw you under this particular bus ;)

#2 Updated by Christopher Wood 9 months ago

Redmine Issue #15090 has been migrated to JIRA:

https://tickets.puppetlabs.com/browse/PUP-1889

Also available in: Atom PDF