Bug #15306
'virtual' fact missing on SmartOS / Solaris
| Status: | Merged - Pending Release | Start date: | 06/29/2012 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% | |
| Category: | - | |||
| Target version: | 1.6.18 | |||
| Keywords: | Affected Facter version: | 1.6.10 | ||
| Branch: | https://github.com/puppetlabs/facter/pull/249 | |||
Description
On a Joyent SmartMachine, facter doens’t report the ‘virtual’ fact. When running facter, the warning “Could not retrieve virtual: invalid byte sequence in UTF-8” is displayed before the output. The root cause is that /proc/self/status is read and checked for a regexp match as part of the test for vserver. However the contents are binary (on this platform) and ruby1.9 throws the exception above. The solution is to read the file in binary mode; I’ll send a pull request.
History
#1
Updated by Jakob Borg 12 months ago
- % Done changed from 0 to 100
A fix is available in https://github.com/puppetlabs/facter/pull/249
#2
Updated by Hailee Kenney 11 months ago
- Status changed from Unreviewed to In Topic Branch Pending Review
#3
Updated by Hailee Kenney 11 months ago
- Branch set to https://github.com/puppetlabs/facter/pull/249
#4
Updated by Jeff McCune 6 months ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
- Target version set to 1.6.18
Merged into 1.6.x as bf19fb3.
This should be released in 1.6.18.
Thanks again for the contribution!
-Jeff