Bug #15924: Ambiguous error if client cert on nodes is empty - MCollective - Puppet Labs

Bug #15924

Ambiguous error if client cert on nodes is empty

Added by Joe McDonagh 10 months ago. Updated 10 months ago.

Status:

Closed

Start date:

08/10/2012

Priority:

Normal

Due date:

Assignee:

% Done:

Category:

Plugins

Target version:

2.1.x

Keywords:

ssl

Affected mCollective version:

Branch:

ploubser/marionette-collective/commits/bug/master/15924

Description

Due to an error in my Puppet config, I was exporting a blank client key for a certain node. So, the pubkey in the ssl client dir on all my nodes was a file of size 0. When I issued commands from this client, I didn’t get any output, and the only error was this in the mcollective.log on the nodes:

W, [2012-08-10T17:13:33.772465 #11525]  WARN -- : runner.rb:91:in `run' Failed to handle message: uninitialized constant MCollective::Security::Aes_security::MsgDoesNotMatchRequestID - NameError

W, [2012-08-10T17:13:33.772650 #11525]  WARN -- : runner.rb:92:in `run' /usr/share/mcollective/plugins/mcollective/security/aes_security.rb:87:in `decodemsg'
    /usr/lib/ruby/1.8/mcollective/runner.rb:140:in `receive'
    /usr/lib/ruby/1.8/mcollective/runner.rb:59:in `run'
    /usr/lib/ruby/1.8/mcollective/runner.rb:57:in `loop'
    /usr/lib/ruby/1.8/mcollective/runner.rb:57:in `run'
    /usr/sbin/mcollectived:53
    /usr/lib/ruby/1.8/mcollective/runner.rb:41:in `daemonize'
    /usr/lib/ruby/1.8/mcollective/runner.rb:33:in `fork'
    /usr/lib/ruby/1.8/mcollective/runner.rb:33:in `daemonize'
    /usr/sbin/mcollectived:44

Probably want to throw an exception with a proper error if file size if 0… sorry for the absence of diff, crazy busy right now