Puppet

Here is the email thread leading up to the ZAML code being merged. In particular Marcus claims the code is licensed under GPL 3+ and MIT: http://www.mail-archive.com/puppet-dev@googlegroups.com/msg07974.html

Given that the main author claims on a public mailing list that it is under the MIT license, how urgent is this now?

I am speaking to Markus currently but whilst he’s stated on the mailing list it’s MIT licensed the only license file attached is GPLv3 so for the moment the problem hasn’t changed.

Tried removing zaml and there are 130 test failures. Some tests fail because of unexpected newlines, which should be benign:

128) Pure ruby yaml implementation should convert the Object # to yaml
     Failure/Error: o.to_yaml.should == y
       expected: "--- !ruby/object {}"
            got: "--- !ruby/object {}\n\n" (using ==)

However, others seem to be significant:

109) Puppet::SimpleGraph (yaml tests) should serialize properly when used as a base class
     Failure/Error: recovered_derived = YAML.load(YAML.dump(derived))
     NoMethodError:
       undefined method `[]' for :@foo:Symbol
...
  120) Pure ruby yaml implementation should convert the Symbol :symbol to yaml
     Failure/Error: o.to_yaml.should == y
       expected: "--- !ruby/sym symbol"
            got: "--- :symbol\n" (using ==)
       Diff:
       @@ -1,2 +1,2 @@
       ---- !ruby/sym symbol
       +--- :symbol
...
126) Pure ruby yaml implementation should produce yaml for the Hash {#<Object:0x10ae70508>=>#<Object:0x10ae704e0>} that can be reconstituted
     Failure/Error: lambda { YAML.load(o.to_yaml) }.should_not raise_error
       expected no Exception, got #<ArgumentError: syntax error on line 2, col -1: `: !ruby/object {}
       
       '>

We don’t need to remove it anymore since it has been relicensed. #16330 tracks updating to the newly licensed version.