Bug #1849

Ruby 1.9 portability: `when' doesn't like colons, replace with semicolons

Added by Jos Backus about 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:01/05/2009
Priority:Low Due date:
Assignee:Jos Backus % Done:

0%
Category:plumbing
Target version:0.25.0
Affected Puppet version:0.24.7 Branch:
Keywords:
Votes: 0

Description

Ruby 1.9 wants

when TrueClass: @@debug = 1

to be written as

when TrueClass; @@debug = 1

Note that the attached patch also changes some when ... then ...' constucts intowhen …; …‘ for consistency’s sake.

when.patch - Patch to change `:' to '`;' in case' statements (75.7 kB) Jos Backus, 01/05/2009 05:04 am

0001-Issue-1849-Ruby-1.9-portability-when-doesn-t-lik.patch (80.4 kB) Jos Backus, 02/26/2009 12:25 am

History

#1
Updated by James Turnbull about 3 years ago

  • Category set to plumbing
  • Status changed from Unreviewed to Accepted
  • Assignee set to Luke Kanies

#2
Updated by Luke Kanies almost 3 years ago

  • Assignee changed from Luke Kanies to Jos Backus

I just tried applying this against master, and I guess we waited to long to apply it.

I assume you just used a simple script to make this patch, so if you could rerun that against current HEAD, I’ll apply immediately. Also, if you use git format-patch to create the patch, you’ll get credit for it in the commit log.

#3
Updated by James Turnbull almost 3 years ago

Jos – any chance of an update – perhaps against 0.24.x HEAD? It’d be good to get this into 0.24.8.

#4
Updated by Jos Backus almost 3 years ago

Patch against 0.24.x HEAD.

#5
Updated by James Turnbull almost 3 years ago

Jos – this has been applied to master HEAD in commit:5f73eb553fd083b558fb9553b0c07b6019d0ccee. The patch applied clean to master but not to 0.24.x.

#6
Updated by James Turnbull almost 3 years ago

  • Status changed from Accepted to Closed

Applied in master. Bumped from 0.24.x

Also available in: Atom PDF