The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #18756

wront regex in util/ip.rb

Added by javier wilson almost 2 years ago. Updated over 1 year ago.

Status:Merged - Pending ReleaseStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:interface
Target version:2.0.0
Keywords: Affected Facter version:1.6.17
Branch:https://github.com/puppetlabs/facter/pull/390

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

if you compare https://github.com/puppetlabs/facter/blob/master/lib/facter/ipaddress.rb#L32

  regexp = /inet (?:addr:)?([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+)/

to https://github.com/puppetlabs/facter/blob/master/lib/facter/util/ip.rb#L8

  :ipaddress => /inet addr:([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+)/,

you can see why the second one will not work in Fedora 16+ where the “addr:” string no longer exists.


Related issues

Related to Facter - Bug #13396: Facter not working with recent net-tools Merged - Pending Release 03/25/2012
Related to Facter - Bug #15001: ipaddress fact fails on Fedora 17 Merged - Pending Release 06/13/2012

History

#1 Updated by David Kowis over 1 year ago

https://github.com/puppetlabs/facter/pull/390

I’ve submitted a pull request for this one. I’m pretty sure I did all the steps right. The fork is off the 1.6.17, since this is only a bugfix.

#2 Updated by Jeff McCune over 1 year ago

  • Category set to interface
  • Status changed from Unreviewed to Merged - Pending Release
  • Target version set to 2.0.0
  • Branch set to https://github.com/puppetlabs/facter/pull/390

Merged into master as 00925c6.

This should be released in Facter 2.

Thanks again for the contribution!

-Jeff

Also available in: Atom PDF