Feature #1934

Add detailed exit codes to puppetd

Added by Robert Lazzurs over 3 years ago. Updated about 2 years ago.

Status:Closed Start date:02/05/2009
Priority:High Due date:
Assignee:Deepak Giridharagopal % Done:

0%
Category:agent
Target version:2.6.0
Affected Puppet version:0.25.0 Branch:
Keywords:
Votes: 3

Description

Hello,

In request #1633 an option was added to puppet for detailed exit codes however this was not added to puppetd.

This feature would be just as useful for one time runs as it would be for testing the behaviour of recipes going through puppet.

Could this please be added to puppetd.

Related issues

duplicated by Puppet - Bug #2162: Exit code 0 on failed puppetd execution Duplicate 04/15/2009

History

#1
Updated by James Turnbull over 3 years ago

  • Status changed from Unreviewed to Needs More Information

I am not sure it works in puppetd. Have you looked at what detailed-exits does? It’s run in conujunction with —noop.

#2
Updated by Luke Kanies over 3 years ago

  • Assignee set to Puppet Community
  • Target version changed from 0.24.8 to 2.6.0

I think this is a decent idea, but I don’t think it’s worth putting into 0.24.8, unless someone else wants to do the work.

#3
Updated by James Turnbull almost 3 years ago

  • Assignee deleted (Puppet Community)

#4
Updated by Nigel Kersten almost 3 years ago

  • Status changed from Needs More Information to Needs Decision
  • Target version changed from 2.6.0 to 4
  • Affected Puppet version changed from 0.24.7 to 0.25.0

So I don’t quite get James' comment about it only being run in conjunction with noop?

Seems like puppetd —onetime —detailed-exitcodes should give the same exit codes as puppet —detailed-exitcodes does.

Having a poke at it now. Marking as needs design decision so more authoritative people can reject it if so, and pushing to 0.25.0

#5
Updated by James Turnbull almost 3 years ago

I am not sure what I meant either. :) I’ll have a poke and try to work out what I meant.

#6
Updated by Nigel Kersten almost 3 years ago

http://projects.reductivelabs.com/issues/2421 seems to be affecting this, but assuming that we’re just taking the same code snippet to work out exit codes…

This isn’t a complete patch, but I wanted to put this up to see whether this is the right spot in the code to do this or not before I go through and make sure this doesn’t break other modes and write tests.

http://github.com/nigelkersten/puppet/commit/1a7b015d25f17194775ef9545bf2e09228382918

#7
Updated by Luke Kanies over 2 years ago

  • Category changed from newfeature to agent
  • Status changed from Needs Decision to Accepted

#8
Updated by James Turnbull over 2 years ago

  • Assignee set to Deepak Giridharagopal
  • Target version changed from 4 to 2.6.0

#9
Updated by Deepak Giridharagopal over 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review

Patch sent to mailing lists; all tests for puppet/puppetd pass.

#10
Updated by Luke Kanies over 2 years ago

  • Priority changed from Normal to High

Bumping because of the votes.

#11
Updated by James Turnbull over 2 years ago

  • Status changed from In Topic Branch Pending Review to Closed

Pushed in commit:2d4b795e81e4f7953210d51be56c77bed3b77609 in branch master.

Also available in: Atom PDF