Refactor #1943

'Yaml' and 'File' terminuses should be combined

Added by Luke Kanies over 3 years ago. Updated about 2 years ago.

Status:Closed Start date:02/07/2009
Priority:Normal Due date:
Assignee:Markus Roberts % Done:

0%

Category:-
Target version:2.6.0
Affected Puppet version:0.24.7 Branch:luke/tickets/master/1943
Keywords:
Votes: 0

Description

We should only have one terminus for storing files; instead, we should specify the format for the resources to be stored in (if any).

This way we can use the FormatHandler code for doing the (de)serializing and reduce the amount of code we have. It also makes it so that our storage format will automatically change with our transport format.

I’d like to get this into 0.25, but I’m not sure I will.


Related issues

related to Puppet - Bug #2892: Improve performance when caching catalog in puppet agent. Accepted 12/04/2009

History

Updated by Luke Kanies about 3 years ago

  • Target version changed from 0.25.0 to 2.6.0

Bumped.

Updated by Luke Kanies over 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee changed from Luke Kanies to Markus Roberts
  • Branch set to luke/tickets/master/1943

This isn’t so much ready for testing as ready for review.

It doesn’t get rid of the yaml terminus type, but rather just modifies the File type to use formats. I figure we want to get rid of yaml in general anyway, so we can just leave it for now.

Updated by James Turnbull over 2 years ago

This code needs a review before testing.

Updated by James Turnbull over 2 years ago

  • Status changed from In Topic Branch Pending Review to Closed

Updated by James Turnbull over 2 years ago

  • Status changed from Closed to In Topic Branch Pending Review

Updated by Markus Roberts about 2 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

Updated by Markus Roberts about 2 years ago

  • Status changed from Merged - Pending Release to Closed

Pushed to master in commit:58920a0bb95b8579162500856b2e6524ff20168e through commit:b41d53596cdcb6d7220b93926f6eedf171c09c46

Also available in: Atom PDF