Some specs slow & may be doing DNS
|Assignee:||James Turnbull||% Done:|
|Affected Puppet version:||0.25.0||Branch:||http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/2567|
Some of the spec tests (e.g. spec/unit/network/authstore.rb) run at wildly different speeds depending on which tests have run before and (possibly) on the state of the local network connection.
The suspicion is that some library is doing reverse DNS lookup or something of the sort.
#3 Updated by Markus Roberts over 3 years ago
- Category changed from testing to network
- Status changed from Accepted to In Topic Branch Pending Review
- Priority changed from Low to Normal
- Branch set to http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/2567
This turned out to be an actual bug in the code rather than just a testing issue; due to the tangled logic it was doing DNS lookups on all non-numeric patterns as they came in (including things like “10.20.30.$1” and “100.101.*”). The variable test times were just a symptom.
Branch up at http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/2567