Bug #2567
Some specs slow & may be doing DNS
| Status: | Closed | Start date: | 08/24/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  James Turnbull | % Done: | 0% | |
| Category: | network | |||
| Target version: | 0.25.2 | |||
| Affected Puppet version: | 0.25.0 | Branch: | http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/2567 | |
| Keywords: | ||||
Description
Some of the spec tests (e.g. spec/unit/network/authstore.rb) run at wildly different speeds depending on which tests have run before and (possibly) on the state of the local network connection.
The suspicion is that some library is doing reverse DNS lookup or something of the sort.
Related issues
History
#1
Updated by Markus Roberts almost 4 years ago
To reproduce, run “spec spec/unit/network/authstore.rb” with slow, fast, and no network connection. Takes ~2 seconds with no network or a fast network, and ~10 with a slow network.
#2
Updated by Markus Roberts over 3 years ago
- Target version set to 0.25.2
#3
Updated by Markus Roberts over 3 years ago
- Category changed from testing to network
- Status changed from Accepted to In Topic Branch Pending Review
- Priority changed from Low to Normal
- Branch set to http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/2567
This turned out to be an actual bug in the code rather than just a testing issue; due to the tangled logic it was doing DNS lookups on all non-numeric patterns as they came in (including things like “10.20.30.$1” and “100.101.*”). The variable test times were just a symptom.
Branch up at http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/2567
#4
Updated by Markus Roberts over 3 years ago
- Assignee changed from Markus Roberts to James Turnbull
#5
Updated by James Turnbull over 3 years ago
- Status changed from In Topic Branch Pending Review to Closed
Pushed as commit:857047d956aa0e78e105df2330346dbd6fcd8c35 and commit:dddbd2821b6602a8d358de1313553dc25b37a998 and commit:18c5165bea26151d446ff9ae63aeee108cb210ef in branch 0.25.x