Bug #2608

install.rb will not run on ruby 1.9.1 due to ftools being deprecated

Added by Al Hoang over 2 years ago. Updated about 2 years ago.

Status:Closed Start date:09/07/2009
Priority:Low Due date:
Assignee:James Turnbull % Done:

0%
Category:installation
Target version:0.25.1
Affected Puppet version:0.25.0 Branch:
Keywords:
Votes: 0

Description

Hi,

I wanted to experiment with Puppet on 1.9.1 however it seems that ftools is deprecated in Ruby 1.9.1 which prevents install.rb from running properly. See the following ruby-core issue for further info: http://redmine.ruby-lang.org/issues/show/1401

Attached is a diff that patches install.rb to use fileutils instead of ftools for the installer that runs fine under Ruby 1.9.1. I tested it with Ruby 1.9.1p243 on a Debian Lenny box

install-rb_for_ruby-1-9-1.diff (1.7 kB) Al Hoang, 09/08/2009 04:44 pm

Related issues

related to Puppet - Bug #2191: Ruby 1.9 portability Duplicate 04/23/2009

History

#1
Updated by James Turnbull over 2 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to James Turnbull
  • Target version set to 0.25.1

#2
Updated by Al Hoang over 2 years ago

  • File install-rb_for_ruby-1-9-1.diff added

Here is an updated patch that uses the ftools method if it can find ftools or else uses fileutils. The old patch would always try to use fileutils.

This is almost the same patch as for #2609 on the Facter project.

#3
Updated by Al Hoang over 2 years ago

  • File deleted (install-rb_for_ruby-1-9-1.diff)

#4
Updated by Al Hoang over 2 years ago

Oops the last patch included an erroneous diff including commit a5c56fcb79b45568b592111959ebda6b11c4c43e.

Here is yet another updated patch that does not include it. Sorry about that.

#5
Updated by Al Hoang over 2 years ago

  • File deleted (install-rb_for_ruby-1-9-1.diff)

#6
Updated by Markus Roberts over 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review

#7
Updated by Markus Roberts over 2 years ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

#8
Updated by James Turnbull over 2 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:19e98f994916482c930005efe938c5f0cac66dec in branch master.

Also available in: Atom PDF