Bug #2609

install.rb will not run on ruby 1.9.1 due to ftools being deprecated

Added by Al Hoang over 2 years ago. Updated over 1 year ago.

Status:Closed Start date:09/07/2009
Priority:Low Due date:
Assignee:Paul Nasrat % Done:

0%
Category:-
Target version:1.5.8
Keywords: Affected Facter version:
Branch:
Votes: 0

Description

Hi,

Due to ftools being deprecated in Ruby 1.9.1 (See http://redmine.ruby-lang.org/issues/show/1401), install.rb for facter will not run properly without modifications.

Attached is a patch that should let facter use ftools if it is available or use fileutils if ftools cannot be found.

I have tested installing facter 1.5.6 with this patch using Ruby 1.9.1p243 on a Debian Lenny box

ruby-1-9-1_ftools.diff (1.8 kB) Al Hoang, 09/07/2009 04:18 pm

bug-2609.diff - Proposed patch that removes the use of ftools.rb altogether (1.6 kB) Jos Backus, 04/13/2010 01:14 am

History

#1
Updated by James Turnbull over 2 years ago

  • Status changed from Unreviewed to Accepted
  • Target version set to 1.5.7

#2
Updated by Paul Nasrat over 2 years ago

  • Assignee set to Paul Nasrat

#3
Updated by Paul Nasrat over 2 years ago

  • Target version changed from 1.5.7 to 1.6.0

#4
Updated by Stéphan Gorget over 2 years ago

I haven’t seen this ticket before creating #2788, I based my patch on #2608, but the patch I submitted in #2788 seems to tackle only 2/3 of what your patch is doing. The last third should be applied too, you should submit it on the mailing list.

#5
Updated by Jos Backus almost 2 years ago

Why not simply use FileUtils always? It should work with both 1.8 and 1.9.

#6
Updated by Jos Backus almost 2 years ago

The patch also fixes a mode issue in the man directories (was 0644, should probably be 0755).

#7
Updated by James Turnbull over 1 year ago

  • Status changed from Accepted to Closed

Pushed in commit:d4b8401dc4b2323a0c162e59e3f98b355d2c3c40 in branch master.

#8
Updated by James Turnbull over 1 year ago

  • Target version changed from 1.6.0 to 1.5.8

Also available in: Atom PDF