install.rb will not run on ruby 1.9.1 due to ftools being deprecated
|Assignee:||Paul Nasrat||% Done:|
||Affected Facter version:||
Due to ftools being deprecated in Ruby 1.9.1 (See http://redmine.ruby-lang.org/issues/show/1401), install.rb for facter will not run properly without modifications.
Attached is a patch that should let facter use ftools if it is available or use fileutils if ftools cannot be found.
I have tested installing facter 1.5.6 with this patch using Ruby 1.9.1p243 on a Debian Lenny box
- Status changed from Unreviewed to Accepted
- Target version set to 1.5.7
- Assignee set to Paul Nasrat
- Target version changed from 1.5.7 to 1.6.0
I haven’t seen this ticket before creating #2788, I based my patch on #2608, but the patch I submitted in #2788 seems to tackle only 2/3 of what your patch is doing.
The last third should be applied too, you should submit it on the mailing list.
Why not simply use FileUtils always? It should work with both 1.8 and 1.9.
The patch also fixes a mode issue in the man directories (was 0644, should probably be 0755).
- Status changed from Accepted to Closed
Pushed in commit:d4b8401dc4b2323a0c162e59e3f98b355d2c3c40 in branch master.
- Target version changed from 1.6.0 to 1.5.8
Also available in: Atom