fact domain empty if domainname doesn't contain a dot (.)
|Assignee:||Hailee Kenney||% Done:|
|Keywords:||domain||Affected Facter version:|
While it may makes some sense (but I don’t know a realworld case) to look further if the domainname doesn’t contain a dot, it sure should be returned if no other can be found.
A real-world use case for a dot-less domain name is setting up a virtual host using ubuntus vmbuilder without specifying an explicit domainname. The domainname will then be ‘defaultdomain’. Strange, but valid for sure. Especially as domainnames parsed from resolv.conf won’t need a dot in them to get accepted.
#2 Updated by Paul Nasrat about 3 years ago
So it looks like the check for containing at least a 2 level dnsdomainname is pretty old
git show 73aeadea
I’ve no particular objection for making this non-null. It’s also been raised on list recently. Obviously DNS allows for alternate root/TLD setups and people do use these.
#9 Updated by Jeff Weiss about 1 year ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
- Assignee set to Hailee Kenney
- Target version changed from 144 to 2.0.0
This was included in the fix for #7484. We can’t set the ticket status to duplicate because of Redmine’s stupid state machine.