Bug #3356

fact domain empty if domainname doesn't contain a dot (.)

Added by Simon Hürlimann over 3 years ago. Updated about 1 year ago.

Status:DuplicateStart date:03/09/2010
Priority:NormalDue date:
Assignee:Hailee Kenney% Done:

0%

Category:library
Target version:2.0.0
Keywords:domain Affected Facter version:
Branch:

Description

While it may makes some sense (but I don’t know a realworld case) to look further if the domainname doesn’t contain a dot, it sure should be returned if no other can be found.

A real-world use case for a dot-less domain name is setting up a virtual host using ubuntus vmbuilder without specifying an explicit domainname. The domainname will then be ‘defaultdomain’. Strange, but valid for sure. Especially as domainnames parsed from resolv.conf won’t need a dot in them to get accepted.

Related issues

Duplicates Facter - Bug #7484: facter fqdn is empty when domainnames aren't containing a... Closed 05/11/2011

History

#1 Updated by James Turnbull about 3 years ago

  • Category set to library
  • Status changed from Unreviewed to Needs Decision
  • Assignee set to Paul Nasrat
  • Target version set to 1.6.0

Paul – again thoughts? Ugliness.

#2 Updated by Paul Nasrat about 3 years ago

So it looks like the check for containing at least a 2 level dnsdomainname is pretty old

git show 73aeadea

I’ve no particular objection for making this non-null. It’s also been raised on list recently. Obviously DNS allows for alternate root/TLD setups and people do use these.

#3 Updated by Paul Nasrat about 3 years ago

  • Status changed from Needs Decision to In Topic Branch Pending Review

Patch sent to list for testing.

Please test and feedback on list/here.

#4 Updated by Rein Henrichs over 2 years ago

  • Status changed from In Topic Branch Pending Review to Tests Insufficient

From Paul’s reply to this patch discussion on the list, it seems that it needs more testing. Changing status accordingly.

#5 Updated by Michael Stahnke almost 2 years ago

  • Target version changed from 1.6.0 to 144

#6 Updated by Adrien Thebo over 1 year ago

  • Assignee deleted (Paul Nasrat)

#7 Updated by Hailee Kenney about 1 year ago

  • Status changed from Tests Insufficient to Code Insufficient

#8 Updated by Hailee Kenney about 1 year ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review

#9 Updated by Jeff Weiss about 1 year ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Assignee set to Hailee Kenney
  • Target version changed from 144 to 2.0.0

This was included in the fix for #7484. We can’t set the ticket status to duplicate because of Redmine’s stupid state machine.

#10 Updated by Jeff Weiss about 1 year ago

  • Status changed from Merged - Pending Release to Closed

#11 Updated by Jeff Weiss about 1 year ago

  • Status changed from Closed to Re-opened

#12 Updated by Jeff Weiss about 1 year ago

  • Status changed from Re-opened to Duplicate

Also available in: Atom PDF