Feature #3435

reports only focus on success/failure, should show applied

Added by Dan Bode about 2 years ago. Updated about 1 year ago.

Status:Closed Start date:03/26/2010
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:-
Target version:1.1.0
Keywords:roadmapped Affected URL:
Branch: Affected Dashboard version:
Votes: 1

Description

There are three main states for reports that we care about in puppet:

  • nothing happened, but puppet ran
  • puppet ran and something changed (but succeeded)
  • something failed

its important in puppet to understand when puppet is modifying systems and this should be introduced as a separate report view.

Related issues

related to Puppet Dashboard - Feature #3535: Display the status of reports from "noop"/audit runs for ... Duplicate 04/12/2010
related to Puppet Dashboard - Feature #5176: Improve reporting support Closed 11/02/2010

History

#1
Updated by Rein Henrichs about 2 years ago

  • Status changed from Unreviewed to Rejected

Report view currently shows all the report data provided by Puppet. When puppet’s reports include event information, it will be included in the Report view.

#2
Updated by Dan Bode about 2 years ago

The following report metrics currently exist:

applied failed restarted total failed_restarts scheduled skipped

failed can be used to indicate failure, and applied to determine if things on the system were modified.

I am referring to the report list view, not the view for individual reports.

#3
Updated by Nigel Kersten over 1 year ago

  • Status changed from Rejected to Accepted
  • Target version set to 1.0.5

#4
Updated by Nigel Kersten over 1 year ago

  • Keywords set to roadmapped

#5
Updated by Matt Robinson over 1 year ago

  • Status changed from Accepted to Needs Decision
  • Assignee set to Nigel Kersten
  • Branch set to https://github.com/mmrobins/puppet-dashboard/tree/ticket/next/3435-reports_have_unchanged_icon

It’s a little confusing what exactly needs to be done in this ticket. Paul and I have created a branch that has a different status and icon to differentiate between reports that succeeded and did nothing, and reports that succeeded and made changes. We’re not sure the new icon is ideal.

The bigger issue though is that this ticket also mentions that something should be “introduced as a separate report view”, and we’re not sure what that report should look like. Should it just show nodes whose most recent run was successful and applied changes?

#6
Updated by Nigel Kersten over 1 year ago

  • Status changed from Needs Decision to Needs More Information
  • Assignee changed from Nigel Kersten to Dan Bode

You’ve achieved the bits I’d been thinking about. Assigning back to Dan for clarification.

#7
Updated by Matt Robinson over 1 year ago

Talking to Dan and Nigel, here’s the clarification for what’s in scope on this ticket:

Stacked Bar Graphs with indicators (green = nothing changed, red = failure, orange = something changed) of node run state.

We already have a patch for icons.

Making the bar graph clickable, adding a report for something changed, and noop status are out of scope for this ticket.

#8
Updated by Nick Lewis over 1 year ago

  • Status changed from Needs More Information to Merged - Pending Release
  • Assignee deleted (Dan Bode)
  • Branch deleted (https://github.com/mmrobins/puppet-dashboard/tree/ticket/next/3435-reports_have_unchanged_icon)

Merged to next in commit:755b6c1e70ce6d7c2d578d4549c5a9c10fe2f1ef

#9
Updated by Matt Robinson over 1 year ago

  • Status changed from Merged - Pending Release to Closed

Merged into master at the end of iteration.

#10
Updated by James Turnbull about 1 year ago

  • Target version changed from 1.0.5 to 1.1.0

Also available in: Atom PDF