Bug #3438
Node show page should display "inherited classes" correctly on Safari
| Status: | Accepted | Start date: | 03/26/2010 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | % Done: | 0% | ||
| Category: | - | |||
| Target version: | - | |||
| Keywords: | Affected URL: | |||
| Branch: | Affected Dashboard version: | |||
Description
Hello,
As the screenshots show it, on Safari the block “inherited classes” is on the right.
Safari version: Version 4.0.5 (6531.22.7) on Mac OSX (10.5.6)
Related issues
History
#1
Updated by Rein Henrichs about 3 years ago
- Status changed from Unreviewed to Accepted
#2
Updated by Rein Henrichs about 3 years ago
- Status changed from Accepted to Needs More Information
Unable to reproduce.
#3
Updated by John Axel Eriksson about 3 years ago
I have the exact same problem in Safari 4.0.5 and had the problem in earlier Safari version as well (Safari was updated recently). Tried using Chrome and the problem isn’t there so it’s not necessarily a webkit problem. Firefox renders correctly as well. The problem is with the Inherited Classes (inherited from group that is) table which gets pushed far to the right and out of view basically. It looks the same here as on the attached screenshot from the original reporter. I’ve had this problem ever since the new dashboard interface was introduced.
#4
Updated by arnaud chong about 3 years ago
How can I help you ?
I wrote a quick fix.
diff --git a/app/views/nodes/show.html.haml b/app/views/nodes/show.html.haml
index 5a16499..b8d00ef 100644
--- a/app/views/nodes/show.html.haml
+++ b/app/views/nodes/show.html.haml
@@ -34,11 +34,10 @@
- else
No Classes
- - unless resource.inherited_classes.empty?
- = inspector_table resource.inherited_classes, :link => true, :caption => 'Inherited Classes'
-
-
.clear
+ - unless resource.inherited_classes.empty?
+ = inspector_table resource.inherited_classes, :link => true, :caption => 'Inherited Classes'
+
- reports = @node.reports.limit(30).order('time ASC')
- unless reports.empty?
Or maybe it could work with an other CSS property than float on the two previous block. (table-cell / column / inline / …).
#5
Updated by Rein Henrichs almost 3 years ago
- Status changed from Needs More Information to Accepted
- Priority changed from Low to Normal
- Target version set to 1.1.0
Thanks! Will get this in ASAP.
#6
Updated by Igal Koshevoy almost 3 years ago
- Target version changed from 1.1.0 to 1.0.5
#7
Updated by Igal Koshevoy almost 3 years ago
- Subject changed from Node display on Safari to Node show page should display "inherited classes" correctly on Safari
#8
Updated by Nick Lewis almost 3 years ago
This should no longer be an issue with the changes in #3531, but I’ll leave it open for now until that goes in.
#9
Updated by Nigel Kersten over 2 years ago
Leaving open and targeted to 1.0.5, Nick, please check this was indeed fixed by #3531
#10
Updated by James Turnbull over 2 years ago
- Target version changed from 1.0.5 to 1.1.0
#11
Updated by James Turnbull about 2 years ago
- Target version deleted (
1.1.0)
#12
Updated by Randall Hansen over 1 year ago
- Assignee set to Devon St.Clair
Devon, I think this is fixed; will you verify?
#13
Updated by Devon St.Clair over 1 year ago
- Assignee changed from Devon St.Clair to Randall Hansen
Wasn’t able to replicate due to the markup changing significantly from a year ago. However, the main issue is a floating one between the ‘Groups’ and ‘Classes’ sections.
Adding a clearfix in the markup solves this problem. This pull request implements a fix. Currently in review.
#14
Updated by Randall Hansen 9 months ago
- Assignee changed from Randall Hansen to Joe Wagner