Node show page should display "inherited classes" correctly on Safari
|Assignee:||Joe Wagner||% Done:|
|Branch:||Affected Dashboard version:|
As the screenshots show it, on Safari the block “inherited classes” is on the right.
Safari version: Version 4.0.5 (6531.22.7) on Mac OSX (10.5.6)
#3 Updated by John Axel Eriksson about 3 years ago
I have the exact same problem in Safari 4.0.5 and had the problem in earlier Safari version as well (Safari was updated recently). Tried using Chrome and the problem isn’t there so it’s not necessarily a webkit problem. Firefox renders correctly as well. The problem is with the Inherited Classes (inherited from group that is) table which gets pushed far to the right and out of view basically. It looks the same here as on the attached screenshot from the original reporter. I’ve had this problem ever since the new dashboard interface was introduced.
#4 Updated by arnaud chong about 3 years ago
How can I help you ?
I wrote a quick fix.
diff --git a/app/views/nodes/show.html.haml b/app/views/nodes/show.html.haml index 5a16499..b8d00ef 100644 --- a/app/views/nodes/show.html.haml +++ b/app/views/nodes/show.html.haml @@ -34,11 +34,10 @@ - else No Classes - - unless resource.inherited_classes.empty? - = inspector_table resource.inherited_classes, :link => true, :caption => 'Inherited Classes' - - .clear + - unless resource.inherited_classes.empty? + = inspector_table resource.inherited_classes, :link => true, :caption => 'Inherited Classes' + - reports = @node.reports.limit(30).order('time ASC') - unless reports.empty?
Or maybe it could work with an other CSS property than float on the two previous block. (table-cell / column / inline / …).
#13 Updated by Devon St.Clair over 1 year ago
- Assignee changed from Devon St.Clair to Randall Hansen
Wasn’t able to replicate due to the markup changing significantly from a year ago. However, the main issue is a floating one between the ‘Groups’ and ‘Classes’ sections.
Adding a clearfix in the markup solves this problem. This pull request implements a fix. Currently in review.