Bug #3702
Log lines on the puppetmaster do not show source Node.
| Status: | Closed | Start date: | 04/29/2010 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | % Done: | 100% |
||
| Category: | server | |||
| Target version: | 2.6.0 | |||
| Affected Puppet version: | 0.25.4 | Branch: | http://github.com/plathrop/puppet/tree/ticket/0.25.x/3702 | |
| Keywords: | ||||
| Votes: | 1 |
Description
It used to be that the logs on the puppetmaster would include (on each line) the source node of the log message. This appears to have gone away at some point, making the puppetmaster logs nearly useless :–)
Related issues
History
Updated by James Turnbull about 2 years ago
- Status changed from Unreviewed to Investigating
Paul do you remember when it was last there? Is this something that changed from 0.24.x and 0.25.x?
Updated by Paul Lathrop about 2 years ago
James,
I don’t recall when it was last there, but since the first Puppet I used in production was 0.24.2, it has to have been after that. I believe 0.24.x does the right thing and 0.25.x does not.
Updated by James Turnbull about 2 years ago
- Assignee set to Luke Kanies
I can’t work out where this was changed – Luke any ideas?
Updated by Luke Kanies about 2 years ago
I can’t for the life of me figure out where it went, but it should be relatively easy to update the ‘source’ on the logs on the server side. Something like (in lib/puppet/reports/log.rb):
self.logs.each do |log|
log.source = "//" + self.host + "/" + log.source
Puppet::Util::Log.newmessage(log)
end
Haven’t tested that, but the basics should be right.
Updated by Luke Kanies about 2 years ago
- Assignee changed from Luke Kanies to Paul Lathrop
Updated by Paul Lathrop about 2 years ago
- Status changed from Investigating to In Topic Branch Pending Review
- Assignee changed from Paul Lathrop to James Turnbull
- % Done changed from 0 to 100
Fix available at http://github.com/plathrop/puppet/tree/ticket/0.25.x/3702
Updated by Markus Roberts about 2 years ago
- Branch set to http://github.com/plathrop/puppet/tree/ticket/0.25.x/3702
Putting the branch in the branch field.
Updated by Paul Lathrop about 2 years ago
Markus Roberts wrote:
Putting the branch in the branch field.
Oops! Forgot that, thanks!
Updated by Markus Roberts about 2 years ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
Updated by James Turnbull about 2 years ago
- Target version set to 2.6.0
Updated by Markus Roberts about 2 years ago
- Status changed from Merged - Pending Release to Closed
Applied to master in commit:722a27fd49fc2c5ac16123e9e34967db025178f5