Bug #4135

pluginsync tries to parse readme files

Added by Dan Bode almost 3 years ago. Updated over 1 year ago.

Status:ClosedStart date:07/02/2010
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:plumbing
Target version:2.7.6
Affected Puppet version:0.25.5 Branch:https://github.com/nanliu/puppet/commit/a2ac7599015a9b53d304126d213f8387d78bd475
Keywords:

Description

I have created the following directory structure in a modulepath:

test
`-- lib
    |-- facter
    |   |-- README.markdown
    |   `-- blah.rb
    `-- puppet
        |-- parser
        |   `-- functions
        |       `-- README.markdown
        |-- provider
        |   `-- README.markdown
        `-- type
            `-- REAME.markdown

pluginsync appears to be trying to check the syntax of all files in the plugins dir (including the READMEs)

the content of all of the README files is ‘blah’

notice the following errors below:

err: Could not load downloaded file /var/lib/puppet/lib/puppet/type/REAME.markdown: undefined local variable or method `blah' for main:Object

# puppetd -t
info: Retrieving plugin
notice: /File[/var/lib/puppet/lib/facter]/ensure: created
notice: /File[/var/lib/puppet/lib/facter/README.markdown]/ensure: content changed '{md5}1d534ac77fc049de534dce45ba7b31b7' to '{md5}1d534ac77fc049de534dce45ba7b31b7'
notice: /File[/var/lib/puppet/lib/facter/blah.rb]/ensure: content changed '{md5}720c2650f67a95c9689bd0e5d713dfde' to '{md5}720c2650f67a95c9689bd0e5d713dfde'
notice: /File[/var/lib/puppet/lib/puppet]/ensure: created
notice: /File[/var/lib/puppet/lib/puppet/parser]/ensure: created
notice: /File[/var/lib/puppet/lib/puppet/parser/functions]/ensure: created
notice: /File[/var/lib/puppet/lib/puppet/parser/functions/README.markdown]/ensure: content changed '{md5}1d534ac77fc049de534dce45ba7b31b7' to '{md5}1d534ac77fc049de534dce45ba7b31b7'
notice: /File[/var/lib/puppet/lib/puppet/provider]/ensure: created
notice: /File[/var/lib/puppet/lib/puppet/provider/README.markdown]/ensure: content changed '{md5}1d534ac77fc049de534dce45ba7b31b7' to '{md5}1d534ac77fc049de534dce45ba7b31b7'
notice: /File[/var/lib/puppet/lib/puppet/type]/ensure: created
notice: /File[/var/lib/puppet/lib/puppet/type/REAME.markdown]/ensure: content changed '{md5}0d599f0ec05c3bda8c3b8a68c32a1b47' to '{md5}0d599f0ec05c3bda8c3b8a68c32a1b47'
info: Loading downloaded plugin /var/lib/puppet/lib/facter/README.markdown
err: Could not load downloaded file /var/lib/puppet/lib/facter/README.markdown: uninitialized constant BLAH
info: Loading downloaded plugin /var/lib/puppet/lib/facter/blah.rb
info: Loading downloaded plugin /var/lib/puppet/lib/puppet/parser/functions/README.markdown
err: Could not load downloaded file /var/lib/puppet/lib/puppet/parser/functions/README.markdown: uninitialized constant BLAH
info: Loading downloaded plugin /var/lib/puppet/lib/puppet/provider/README.markdown
err: Could not load downloaded file /var/lib/puppet/lib/puppet/provider/README.markdown: uninitialized constant BLAH
info: Loading downloaded plugin /var/lib/puppet/lib/puppet/type/REAME.markdown
err: Could not load downloaded file /var/lib/puppet/lib/puppet/type/REAME.markdown: undefined local variable or method `blah' for main:Object
info: Loading facts in blah
info: Loading facts in blah
info: Caching catalog for puppetclient
info: Applying configuration version '1277611559'
notice: Finished catalog run in 0.03 seconds

Related issues

Blocks Facter - Feature #9546: Plugin sync support for external facts Accepted 05/19/2012 05/19/2012

History

#1 Updated by James Turnbull almost 3 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Markus Roberts
  • Target version set to 2.6.1

So in light of the Forge this needs to be fixed ASAP. Markus I am assigning to you for your thoughts.

#2 Updated by Alan Barrett almost 3 years ago

workaround:

=begin comment

real contents of readme file go here

=end comment

#3 Updated by James Turnbull almost 3 years ago

  • Target version changed from 2.6.1 to 2.6.2

#4 Updated by Paul Berry over 2 years ago

  • Target version changed from 2.6.2 to 52

Setting target version to “queued”, since we would prefer to limit 2.6.x releases to fixing bugs that were introduced in 2.6.

#5 Updated by Markus Falb over 2 years ago

Alan Barrett wrote:

workaround:

[…]

I just tested and think I found another workaround. Set on client puppet.conf the factsignore and pluginsignore. I have

factsignore = .svn CVS .git *.markdown .*.swp
pluginsignore = .svn CVS .git *.markdown .*.swp

#6 Updated by James Turnbull over 2 years ago

  • Target version deleted (52)

#7 Updated by Nan Liu almost 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review

Wrote a simple patch so it doesn’t load any non-ruby files. Not sure if this has other impact so this should be reviewed. https://github.com/nanliu/puppet/commit/a2ac7599015a9b53d304126d213f8387d78bd475

#8 Updated by James Turnbull almost 2 years ago

  • Assignee deleted (Markus Roberts)
  • Branch set to https://github.com/nanliu/puppet/commit/a2ac7599015a9b53d304126d213f8387d78bd475

#9 Updated by Stefan Schulte almost 2 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

merged to 2.7.x in commit:5210f8d7748158d47bb83aaeb658fa621587e111

#10 Updated by Michael Stahnke over 1 year ago

  • Status changed from Merged - Pending Release to Closed
  • Target version set to 2.7.6

Released in 2.7.6rc1.

Also available in: Atom PDF