Bug #4529
Commits should be emailed to a mailing list
| Status: | Duplicate | Start date: | 08/12/2010 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Matt Robinson |
% Done: | 0% |
|
| Category: | - | |||
| Target version: | 1.0.4 | |||
| Keywords: | mail community | Affected URL: | ||
| Branch: | Affected Dashboard version: | |||
| Votes: | 1 |
Description
Currently we don’t have an equivalent of what puppet does which is mail patches to a community list. Not a huge issue right now as we don’t have a lot of external contributors, but it could help in giving community members visibility into the fact that dashboard is making progress.
History
Updated by Igal Koshevoy over 1 year ago
I recognize and accept that this is what’s used for Puppet core development, and understand that there are reasons why this makes sense.
However, is this needed for Dashboard or Forge? If the people want to see that someone is working on the, they can ask or just watch our repos and tickets. If they want to contribute, they can open tickets and submit patches, and we’ll deal with them the same way we’ve dealt with each other’s contributions on Dashboard: discussing, reviewing and hopefully merging completed code.
I also worry about using the list because it adds steps to the workflow (e.g. mailing patches and waiting for +1s from someone) and is harder to manually track status than with the ticketing system.
Thoughts?
Updated by James Turnbull over 1 year ago
So I pretty much don’t agree. :)
For Forge … perhaps not. But for Dashboard – yes we should send every commit to the -dev list – irrelevant of whether it gets +1'ed or not. A lot of the sending to the -dev list is about exposing the community to the code and in the case of Puppet and Facter we’ve gotten valuable feedback on commits and sometimes even detection of bugs and errors in commits that would otherwise have gotten through. Our community is also heavily email based and doesn’t regularly review the ticket DB or list. This is a good way of communicating to them what features and bugs are being fixed. Finally – our lists are far better search-enabled (being Google lists) than Redmine – I find code, bugs and fixes show up much better in Google when they have been sent to the mailing list too.
Updated by James Turnbull over 1 year ago
- Status changed from Unreviewed to Needs Decision
Updated by Matt Robinson over 1 year ago
- Subject changed from Create a 'rake mail_patches' for Dashboard to Commits should be emailed to a mailing list
- Status changed from Needs Decision to Accepted
- Assignee set to Matt Robinson
- Target version set to 1.0.5
Talking in person with Igal we think creating a dashboard-commits@puppetlabs.com mailing list and automating the sending of commit messages using github would be great (look under github’s project->admin->service hooks->email).
Since it’s automated, it overcomes Igals' objection of adding extra steps. Creating a separate mailing list makes it easy for those who don’t want to get the email to opt out.
Igal suggested we run this by Markus, so I’m adding him to the watchers. I’ll assign this to me so that I can keep this ticket moving. Once everyone agrees on what they want, this will probably require an infrastructure ticket to create the mailing list (if that’s what people agree is good).
Updated by Igal Koshevoy over 1 year ago
- Status changed from Accepted to Duplicate
This was resolved in #4757 “Add mail_patches task to Puppet Dashboard project”.
Updated by Igal Koshevoy over 1 year ago
- Target version changed from 1.0.5 to 1.0.4
Updated by Matt Robinson about 1 year ago
- Tracker changed from Feature to Bug
Good points, and after thinking about it I would rather change this to have email notification when things get merged into github.
Explanation of thoughts below.
On Thu, Aug 12, 2010 at 3:22 PM, tickets@puppetlabs.com wrote:
However, is this needed for Dashboard or Forge?
Definitely not needed for Forge as it’s not open source.
If the people want to see that someone is working on the, they can ask or just watch our repos and tickets. If they want to contribute, they can open tickets and submit patches, and we’ll deal with them the same way we’ve dealt with each other’s contributions on Dashboard: discussing, reviewing and hopefully merging completed code.
I agree in theory, but everyone checks their email, and it’s difficult to remember to check those other places.
I also worry about using the list because it adds steps to the workflow (e.g. mailing patches and waiting for +1s from someone) and is harder to manually track status than with the ticketing system.
I guess I don’t think we need the +1’s on the list for the code to go in. In fact, I would prefer the +1 didn’t happen at this point in the puppet process either (I’d rather this happened on the ticket, or even better in a merge commit, but that’s a different topic for puppet). But I do like getting emails when patches get merged in, including my own as I’m sometimes not sure when that will happen. I guess what I’d really prefer is that the list automatically get an email whenever something is merged into github. If this could be automated it wouldn’t add a step to the workflow, it would increase visibility for those who forget to check the commit logs.
Updated by Matt Robinson about 1 year ago
James, So it sounds like you’d agree that a post commit hook in github would be fine then? I know that means the code would get in before people could catch bugs, but if they catch them we can fix them with another patch. That would be easy to setup (service hooks on the admin page for github allows you to create the email hook), it wouldn’t add anything to our workflow, and our mailing list would get the commit messages.
I tried it out with a repo of mine, and the only downside is that you don’t get the patch in the email. You get the commit message, the list of changed files, and a link to the diffs on github, which are a lot more readable. It means the patch wouldn’t be in the searchable email, but usually the ticket number and commit message are what you want to search anyway.
I actually wish Puppet did this because I hate reading the commits in email, and even though I can find the commit on github it sure would be nice if there were links to github where the diff is a lot easier to read. However, it would be a bit annoying to get both the precommit to +1 and then the commit message again once it goes in to github, but it would be nice to know when commits went in, because sometimes it can take a while for things to actually get merged. Matt
On Thu, Aug 12, 2010 at 7:36 PM, tickets@puppetlabs.com wrote:
Issue #4529 has been updated by James Turnbull.
So I pretty much don’t agree. :)
For Forge … perhaps not. But for Dashboard – yes we should send every commit to the -dev list – irrelevant of whether it gets +1'ed or not. A lot of the sending to the -dev list is about exposing the community to the code and in the case of Puppet and Facter we’ve gotten valuable feedback on commits and sometimes even detection of bugs and errors in commits that would otherwise have gotten through. Our community is also heavily email based and doesn’t regularly review the ticket DB or list. This is a good way of communicating to them what features and bugs are being fixed. Finally – our lists are far better search-enabled (being Google lists) than Redmine – I find code, bugs and fixes show up much better in Google when they have been sent to the mailing list too.
Feature #4529: Create a ‘rake mail_patches’ for Dashboard
Author: Matt Robinson Status: Unreviewed Priority: Normal Assigned to: Category: Target version: Keywords: mail community Branch: Affected URL:
Currently we don’t have an equivalent of what puppet does which is mail patches to a community list. Not a huge issue right now as we don’t have a lot of external contributors, but it could help in giving community members visibility into the fact that dashboard is making progress.
You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account