Bug #4691

$name initial-uppercased

Added by Dan Urist over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:09/02/2010
Priority:High Due date:
Assignee:Markus Roberts % Done:

0%

Category:-
Target version:2.6.1
Affected Puppet version:2.6.1rc2 Branch:http://github.com/MarkusQ/puppet/tree/tickets/2.6.x/4691
Keywords:
Votes: 0

Description

The $name variable is initial-uppercased in modules in 2.6.1rc2; 0.25 did not do this.


Related issues

related to Puppet - Bug #4736: $name should preserve specified case Closed 09/08/2010

History

Updated by James Turnbull over 1 year ago

  • Status changed from Unreviewed to Accepted
  • Priority changed from Normal to High
  • Target version set to 2.6.1

Updated by Markus Roberts over 1 year ago

  • Assignee set to Markus Roberts

Looks like it’s not just modules; regular classes in site.pp do this too.

class xyz { notify { "Name is '$name', should be 'xyz'":}}
node default { include xyz }

Updated by Markus Roberts over 1 year ago

The change came in in af9a920..07cfdd0, which doesn’t help as much as I’d like.

Updated by Markus Roberts over 1 year ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to http://github.com/MarkusQ/puppet/tree/ticket/2.6.x/4691

I ran out of time to figure out why the change occurred (it appears to be a consequence of how we store classes). Things I don’t understand at the moment: 1) why the change was made, 2) why the ticket is considered “high”, 3) what you’d even use $name for in the first place. The attached branch is a phenomenological fix; it just downcases the name as set in $name.

This should be minimal impact.

Updated by Markus Roberts over 1 year ago

  • Branch changed from http://github.com/MarkusQ/puppet/tree/ticket/2.6.x/4691 to http://github.com/MarkusQ/puppet/tree/tickets/2.6.x/4691

Updated by James Turnbull over 1 year ago

  • Status changed from In Topic Branch Pending Review to Closed

Pushed in commit:763e7cb6f3f8e1104ab1da515701de1dfc8f57e9

Also available in: Atom PDF