Bug #4736

$name should preserve specified case

Added by Alan Harder over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:09/08/2010
Priority:Urgent Due date:
Assignee:Markus Roberts % Done:

0%
Category:plumbing
Target version:2.6.1
Affected Puppet version:2.6.1rc4 Branch:http://github.com/MarkusQ/puppet/tree/ticket/2.6.x/4736
Keywords:
Votes: 1

Description

This seems to be a change between 2.6.1rc3 and rc4.

define foo {
  notify { "notify_$name": }
}
node default {
  foo { "ABCdef": }
}

This results in “notice: notify_abcdef” instead of ABCdef. I have some defines that use the $name in shell calls that are case sensitive.

I set the priority to Urgent so hopefully this is at least looked at and considered before 2.6.1 final.. feel free to lower the priority.

Related issues

related to Puppet - Bug #4691: $name initial-uppercased Closed 09/02/2010
duplicated by Puppet - Bug #4805: $name gets interpolated incorrectly Duplicate 09/19/2010
duplicated by Puppet - Bug #4733: Realizing virtual resources fails Duplicate 09/07/2010
duplicated by Puppet - Bug #4886: When I call a define, the $name passed in is 'mangled' to... Duplicate 09/30/2010

History

#1
Updated by James Turnbull over 1 year ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Markus Roberts
  • Target version set to 2.6.1
  • Affected Puppet version set to 2.6.1rc4

Markus – looks like the $name fix had inadvertent consequences.

#2
Updated by Markus Roberts over 1 year ago

  • Subject changed from Resource names changed to lowercase to $name should preserve specified case

This is a consequence of #4691 being mis-specified.

It appears that the desired behavior is “preserve case” rather than “not capitalized.”

#3
Updated by Markus Roberts over 1 year ago

It appears that $title is exhibiting the same behavior as $name did prior to #4691 (initial capital, everything else lower case).

#4
Updated by Markus Roberts over 1 year ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to http://github.com/MarkusQ/puppet/tree/ticket/2.6.x/4736

The change restricts the fix applied in #4691 to classes (leaving defined resources as they had been before the change) and extends it to the class title, which had been analogously affected by the refactor that started this all.

#5
Updated by R.I. Pienaar over 1 year ago

I’ve tested this commit on my problem host and it resolves my virtual resource problem.

#6
Updated by James Turnbull over 1 year ago

  • Status changed from In Topic Branch Pending Review to Closed

Pushed in commit:14b33402812756dc0cd3e84619afa211d449d59f in 2.6.x

Also available in: Atom PDF