Puppet

Just wanted to say that I’m currently working on this issue. The tests I did on my own system worked so far but I haven’t finished writing specs for it.

https://github.com/stschulte/puppet/commits/ticket/2.6.x/4914

My approach is the following:

• let the parsefile provider prefetch all resources in /etc/(v)fstab but set the ensure state to :unmounted instead of :present
• now run the mount command and parse all mounted resource. We will now update the ensure state from either :unmounted (already found in fstab) to :mounted or from :absent (not in fstab) to :ghost. To query the mountstate of a given resource we can check if ensure in the prefetched property_hash is :mounted or :ghost and don’t need to run mount again.

Sounds good Stefan. One comment while you’re in there:

The current provider does not correctly interact with the OS when the mount device changes for an NFS mount; it considers this a ‘remount’ and executes ‘mount -o remount /mnt/point’ — but this does not cause the new, changed exporting device to be mounted. A full unmount/remount needs to be done in that case. As a nasty workaround I have a local hack that turns off :remounts param for every OS I run. Otherwise you get this:

notice: //nfs::workspace/Nfs::Mount[/opt/workspace]/Mount[/opt/workspace]/device: device changed 'filer001:/vol/vol1/workspace' to 'filer001:/vol/vol3/perfworkspace'info: Filebucket[/var/lib/puppet/clientbucket]: Adding /etc/fstab(09e507fe528f497d0d40708877ab7fc1)notice: //nfs::workspace/Nfs::Mount[/opt/workspace]/Mount[/opt/workspace]: Refreshing self
info: Mount[/opt/workspace](provider=parsed): Remounting

# and yet...
filer001:/vol/vol1/workspace 3182218496 272897920 2909320576       9% /opt/workspace

Eric, can you please file this as a seperate bug report (if not already done). And I guess this isn’t necessarily a NFS problem because according to the Linux manpage remount will not use another device:

Attempt to remount an already-mounted filesystem. This is commonly used to change the  mount flags
for a filesystem, especially to make a readonly filesystem writeable. It does not change device or
mount point.

Currently any change to the mount or any external notify will call refresh. But at this point we don’t know what caused the refresh. So when do we need to remount at all?

• external notfiy: normal remount
• device changed: umount, mount
• options changed: normal remount
• pass, dump, atboot, ensure changed: nothing?

commit:2884660768fbea22a91e3c5bab9595ce075e67a5

FWIW, for our ~650 line vfstab (don’t ask…) this change has reduced catalog runtime from 2-4 minutes to 30 seconds. Thanks!!