Puppet » Puppet Dashboard

Commit ad7a1c1f attempts to add sorting, but instead adds a bunch of bugs. Commit 3c48dadb attempts to add workarounds to fix some, but possibly not all, of the bugs in the earlier commit, and possibly adds a new bug by removing some sorting. These two commits are badly-designed, inefficient and the work should be redone. Do not “.sort” unsortable objects. Do not sort database records with Ruby (e.g. “.sort” and “<=>”) — use the database to sort database records. Do not add model logic (e.g. custom sorting) to views — put model logic into models. Do not use default model sorting because it slows down all queries using that model, and many queries won’t need that sorting. Do write tests, they would have caught these bugs. Do check that your code works, simply loading the pages would have caught these bugs.