Bug #5389
Report migrations should run quickly
| Status: | Closed | Start date: | 11/24/2010 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: |  Nick Lewis |
% Done: | 0% |
|
| Category: | - | |||
| Target version: | - | |||
| Keywords: | Affected URL: | |||
| Branch: | Affected Dashboard version: | 1.0.5 | ||
| Votes: | 0 |
Description
Commit 1cff89cf introduces a very slow migration that ran for an hour on my small database. I estimate that this migration will take over a WEEK to run on our larger customer sites. That’s probably not acceptable to many of our users. Please consider going back and figuring out how to do this more efficiently. I suspect the problem is that you’re using ActiveRecord to load and resave all the reports. Can you use SQL to do this more efficiently?
History
Updated by Igal Koshevoy over 1 year ago
- Status changed from Unreviewed to Rejected
Never mind. I’m rejecting this ticket because I don’t think it’s possible to do this reasonably with SQL. This migration has to load report objects, parse them to count how many resources changed, and then set the “status” value based on this.
Updated by Nigel Kersten over 1 year ago
- Target version deleted (
1.0.5) - Affected Dashboard version set to 1.0.5
Updated by Nick Lewis over 1 year ago
- Status changed from Rejected to Re-opened
We’ve decided to write quick migrations that make some assumptions about their data, and later rectify it with a rake task which rebuilds the reports table based on the report yaml. We’re also adding sanity checks/repairs on individual reads. So I’m reopening this ticket to cover that.
Updated by Nigel Kersten over 1 year ago
- Assignee set to Nick Lewis
Can I get a picture from you Nick as to what the actual status is? I see the ticket was reopened, but not sure what we’re meant to be doing from here.
Updated by Nick Lewis over 1 year ago
The particular migration this was written about has been superseded by the report schematization work. It’s no longer an issue and this ticket was simply missed and can be closed.
Updated by James Turnbull over 1 year ago
- Status changed from Re-opened to Closed