The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com
Puppet should handle port entries in /etc/services with a native type
|Status:||Tests Insufficient||Start date:||12/23/2010|
|Assignee:||Stefan Schulte||% Done:|
|Affected Puppet version:||Branch:||https://github.com/stschulte/puppet/tree/feature/next/5660|
Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com
This ticket may be automatically exported to the PUP project on JIRA using the button below:
There already is a puppet type called
port.rb in the puppet sources which is currently commented out.
/etc/services should be easy to handle with the parsedfile provider the only complicated thing is that we don’t have one single key to address one entry. Only the combination of name AND protocol has to be uniq.
#1 Updated by Stefan Schulte over 3 years ago
- Branch set to https://github.com/stschulte/puppet/tree/feature/next/5660
#3 Updated by Jacob Helwig over 3 years ago
- Status changed from In Topic Branch Pending Review to Tests Insufficient
As posted on the mailing list:
Stefan, I started taking a look at the patch series, but it doesn't look like the tests run at all. I get an error about trying to use pupepttest/support/utils /home/jhelwig/.rvm/rubies/ruby-1.8.7-p302/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require': no such file to load -- puppettest/support/utils (LoadError) from /home/jhelwig/.rvm/rubies/ruby-1.8.7-p302/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require' from /home/jhelwig/work/puppet/spec/unit/provider/port/parsed_spec.rb:6 from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/gems/rspec-core-2.5.1/lib/rspec/core/configuration.rb:386:in `load' from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/gems/rspec-core-2.5.1/lib/rspec/core/configuration.rb:386:in `load_spec_files' from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/gems/rspec-core-2.5.1/lib/rspec/core/configuration.rb:386:in `map' from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/gems/rspec-core-2.5.1/lib/rspec/core/configuration.rb:386:in `load_spec_files' from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/gems/rspec-core-2.5.1/lib/rspec/core/command_line.rb:18:in `run' from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/gems/rspec-core-2.5.1/lib/rspec/core/runner.rb:55:in `run_in_process' from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/gems/rspec-core-2.5.1/lib/rspec/core/runner.rb:46:in `run' from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/gems/rspec-core-2.5.1/lib/rspec/core/runner.rb:10:in `autorun' from /home/jhelwig/.rvm/gems/ruby-1.8.7-p302@rspec2/bin/rspec:19 It looks like the new test is the only one attempting to use puppettest from within the spec test framework. It looks like this will need to get sorted out before we can merge it in. I'm assuming that these tests are running fine for you. Anything I should be aware of to get them running on my end?