Puppet

My current stance is:

• We should probably always print this output.
• I don’t know what we should do about stderr, which seems equally important for these commands given we rely upon the exit code.

Sold!

I’m convinced. Let’s do it.

I can’t tell if a CLA was signed by the original submitter or not. We can’t use that code without tracking that down.

A reimplementation without reference should be trivial, though, if someone wants to step up to the plate.

This isn’t a 2.7 feature by this point, though.

How about we ask the author to sign one – hence my comment about him being on the thread. And there’s nothing wrong with adding the code in the diff here.

Hi Morgan – any chance you could please sign a CLA for your patch in http://groups.google.com/group/puppet-dev/browse_thread/thread/4b8d5779a3a42216? Just click on the link in the top right menu. Many thanks!

Morgan – thanks so much for signing the CLA!

This is the proposed code. It’d be great to have this in a branch with a pull request too if possible but if you can’t do it we’ll handle it. Many thanks again!

diff --git a/configurer.rb b/configurer.rb 
index 31d31c2..194acc1 100644 
--- a/configurer.rb 
+++ b/configurer.rb 
@@ -41,11 +41,11 @@ class Puppet::Configurer 
   end 

   def execute_postrun_command 
-    execute_from_setting(:postrun_command) 
+    execute_from_setting(:postrun_command, Puppet[:print_postrun_output]) 
   end 

   def execute_prerun_command 
-    execute_from_setting(:prerun_command) 
+    execute_from_setting(:prerun_command, Puppet[:print_prerun_output]) 
   end 

   # Initialize and load storage 
@@ -200,11 +200,14 @@ class Puppet::Configurer 
     timeout 
   end 

-  def execute_from_setting(setting) 
+  def execute_from_setting(setting, print_output = false) 
     return if (command = Puppet[setting]) == "" 

     begin 
-      Puppet::Util.execute([command]) 
+      output = Puppet::Util.execute([command]) 
+      if print_output then 
+        Puppet.info(output) 
+      end 
     rescue => detail 
       raise CommandHookError, "Could not run command from #{setting}: 
#{detail}" 
     end 
diff --git a/defaults.rb b/defaults.rb 
index 4521a59..e0d2cda 100644 
--- a/defaults.rb 
+++ b/defaults.rb 
@@ -168,6 +168,12 @@ module Puppet 
     :postrun_command => ["", "A command to run after every agent run.  If 
this command returns a non-zero 
       return code, the entire Puppet run will be considered to have failed, 
even though it might have 
       performed work during the normal run."], 
+    :print_prerun_output => [false, 
+      "Boolean; whether to print output from the prerun_command at the 
'info' level." 
+    ], 
+    :print_postrun_output => [false, 
+      "Boolean; whether to print output from the postrun_command at the 
'info' level." 
+    ], 
     :freeze_main => [false, "Freezes the 'main' class, disallowing any code 
to be added to it.  This 
       essentially means that you can't have any code outside of a node, 
class, or definition other 
       than in the site manifest."]