Bug #6403

vcsrepo will disply warning if multiple version control executables are installed

Added by Dan Bode over 2 years ago. Updated 4 months ago.

Status:Merged - Pending ReleaseStart date:02/22/2011
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:vcsrepoSpent time:-
Target version:-
Keywords:vcsrepo 0.1.1 Branch:https://github.com/puppetlabs/puppetlabs-vcsrepo/pull/35

Description

on the machine, both cvs and svn are installed

warning: Found multiple providers for vcsrepo: svn, cvs; using svn

History

#1 Updated by James Turnbull about 2 years ago

  • Status changed from Unreviewed to Accepted

#2 Updated by Ken Barber almost 2 years ago

  • Category set to vcsrepo

#3 Updated by Nan Liu over 1 year ago

Every vcsrepo has a defaultfor defaultfor :command => :exists. In this case, I’m wondering if it makes sense not to have any defaults since the end user most likely have to be explicit about provider rather than haphazardly depend what’s on the system.

#4 Updated by micah - over 1 year ago

I get this message on a system that only has git installed, yet it still picks the default as ‘svn’.

I agree with Nan Liu’s comment 5 months ago, there is no sense is guessing what the provider should be, the type of repository should just be a required parameter.

#5 Updated by Aaron Stone 8 months ago

I just posted about this in #16598 — reading the code, I suspect there’s a way we can mark which provider will be the default in the event of multiple providers being “suitable” (meaning: they have the requisite binaries available).

This does not appear to have anything to do with not specifying a provider in an instance of vcsrepo — rather, puppet’s types system always wants to figure what might be the default provider for a type.

#6 Updated by Aaron Stone 8 months ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Keywords set to vcsrepo 0.1.1
  • Branch set to https://github.com/puppetlabs/puppetlabs-vcsrepo/pull/35

#7 Updated by Aaron Stone 8 months ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

Fixed in vcsrepo 0.1.1

Also available in: Atom PDF