Feature #651

Exec checks should be turned into metaparameters

Added by Digant Kasundra almost 5 years ago. Updated 22 days ago.

Status:Accepted Start date:
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:RAL
Target version:3.X
Affected Puppet version:0.24.4 Branch:
Keywords:
Votes: 19

Description

The ‘checks’ in Exec — refreshonly, onlyif and unless — should be changed into metaparameters, so they’re available for all resource types.

My guess is that this will require defining a new type of metaparameter, in the same way that the Exec checks are a slightly different type of parameter.

Related issues

related to Puppet - Bug #2417: mount type doesn't handle enforcing options correctly whe... Accepted 07/16/2009
duplicated by Puppet - Bug #4023: refreshonly should be a metaparameter Duplicate 06/17/2010
duplicated by Puppet - Feature #3179: Notify resource should support refreshonly a la exec. Duplicate 02/12/2010
duplicated by Puppet - Feature #2223: Make onlyif a meta-parameter Duplicate 05/05/2009
duplicated by Puppet - Feature #1225: Move onlyif/unless into metaparameters Duplicate
duplicated by Puppet - Feature #1446: Make onlyif, unless metaparameters Duplicate 07/23/2008
duplicated by Puppet - Feature #1902: Add onlyif and unless as basic metaparameters for all types Duplicate 01/27/2009

History

#1
Updated by Luke Kanies almost 5 years ago

I think that we should just move all of the exec checks (unless, onlyif, and possibly creates) to work on all types, rather than just exec.

#2
Updated by Redmine Admin almost 4 years ago

  • Status changed from 1 to Needs Decision

#3
Updated by Luke Kanies over 3 years ago

  • Subject changed from Service should support "unless" to Exec checks should be turned into metaparameters
  • Status changed from Needs Decision to Accepted
  • Assignee changed from Luke Kanies to Puppet Community
  • Affected Puppet version set to 0.24.4

#4
Updated by Luke Kanies over 3 years ago

  • Status changed from Accepted to Duplicate

Duplicate of #651.

#5
Updated by Luke Kanies over 3 years ago

  • Status changed from Duplicate to Accepted

This wasn’t supposed to be marked a duplicate — the others were.

#6
Updated by Jeff Goldschrafe over 3 years ago

I’m chiming in to note that the new Augeas type in 0.24.7 has an onlyif parameter that functions differently from exec’s, and that may block this.

#7
Updated by Luke Kanies over 3 years ago

  • Target version changed from 0.25.0 to 4

#8
Updated by James Turnbull almost 3 years ago

  • Assignee deleted (Puppet Community)

#9
Updated by Klavs Klavsen almost 3 years ago

Me too :)

Just opened ticket #2417 – and this ticket would def. solve that tickets problem.

Currently I made a fact $tmpdevice, which greps for the existence of a /tmp mountpoint in /etc/fstab – and wrap the mount in an if $tmpdevice.

#10
Updated by Luke Kanies over 2 years ago

  • Target version changed from 4 to 2.6.0

#11
Updated by Roy Nielsen over 2 years ago

So far I have made a basic change to add an :unless metaparameter — it doesn’t have all the checks that exec has, but it semi-functions. The problem is that it currently exits the puppet run with an error if the condition is met.

I’m having trouble figuring out how to use the transaction class to “skip” a resource if the condition is met rather than exit the run entirely.

Code: http://github.com/amrset/puppet/blob/master/lib/puppet/type.rb

Regards, -Roy

#12
Updated by James Turnbull over 2 years ago

  • Target version changed from 2.6.0 to 2.7.x

#13
Updated by Nigel Kersten over 1 year ago

  • Assignee set to Nigel Kersten

Roy, I’m really sorry we let this languish so long. Is that code still valid?

#14
Updated by Corey Osman about 1 year ago

Any updates on this? I would also like to have onlyif available to all types. See my post regarding onlyif for ssh_authorized_key type.

http://groups.google.com/group/puppet-users/browse_thread/thread/880199dc6292f8dd

#15
Updated by Nigel Kersten about 1 year ago

  • Assignee deleted (Nigel Kersten)
  • Target version changed from 2.7.x to 3.X

Yep. We’ve had a couple of half-done attempts to provide this, but it’s not as trivial as it sounds.

Also available in: Atom PDF