Bug #6513

Settings code does not propagate environment

Added by Markus Roberts about 1 year ago. Updated about 1 year ago.

Status:Closed Start date:02/28/2011
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:settings
Target version:2.6.7
Affected Puppet version: Branch:https://github.com/jhelwig/puppet/tree/ticket/2.6.x/6513-propigate-environment-in-settings-values
Keywords:
Votes: 0

Description

The code in settings does not always propagate the environment, creating situations in which inconsistent results can be produced. A simple (albeit highly contrived) example, given:

test.conf

[master]
    rrddir = /var/lib/puppet/rrd
    templatedir = /var/lib/puppet/templates
[env_a]
    templatedir = $rrddir/templates
    rrddir = /tmp/env_a/

the command:

RUBYLIB=lib bin/puppet master --config ./test.conf --environment env_a --configprint templatedir

produces “/var/lib/puppet/rrd/templates” instead of the expected “/tmp/env_a/templates”

This was independently discovered by Jacob Helwig & Seth Samuel by code inspection; there are no known reports of it in the wild.

History

#1
Updated by Jacob Helwig about 1 year ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to https://github.com/jhelwig/puppet/tree/ticket/2.6.x/6513-propigate-environment-in-settings-values

This should be fixed in https://github.com/jhelwig/puppet/tree/ticket/2.6.x/6513-propigate-environment-in-settings-values

#2
Updated by Jacob Helwig about 1 year ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

Reviewed with Jesse Wolfe, and pushed to 2.6.next in commit:2092e61264899c742924a30148ebe1e079b60d38

#3
Updated by James Turnbull about 1 year ago

  • Status changed from Merged - Pending Release to Closed
  • Target version set to 2.6.7

Also available in: Atom PDF