Puppet

The code base contains many occurrences of the pattern:

      def initialize(..., options = {:op1 => 'default1'})
         options.each { |opt, val| send(opt.to_s + "=", val) } 
         :

This is problematic for several reasons; it should be replaced with something like:

      def initialize(..., options = {})
         options = {
            :opt1 => 'default',
            :opt2 => 'default2',
            :
          }.update options
         @opt1 = options.delete(:opt1)
         @opt2 = options.delete(:opt2)
         :
         raise "Unknown options: #{options.inspect}" unless options.empty?
         :

If inheritance is an issue this can be augmented to:

(in the base)

      def initialize(..., options = {})
         parse_options({
            :opt1 => 'default',
            :opt2 => 'default2',
            :
          }.update options)
         :

      def parse_options(options)
         @opt1 = options.delete(:opt1)
         @opt2 = options.delete(:opt2)
         :
         raise "Unknown options: #{options.inspect}" unless options.empty?
         :

(in children)

      def initialize(..., options = {})
         super(...,{
            :opt3 => 'default3',
            :opt4 => 'default4',
            :
          }.update options)
         :

      def parse_options(options)
        @opt3 = options.delete(:opt3)
        @opt4 = options.delete(:opt4)
        :
        super(options)
      end