The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #7314

Faces should not fail when it finds an invalid face

Added by Dan Bode almost 3 years ago. Updated 11 months ago.

Status:ClosedStart date:05/02/2011
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Faces
Target version:2.7.0
Affected Puppet version:2.7.0rc1 Branch:
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

The below example fails b/c /usr/local/dev/interface-utils/lib/puppet/face/dashboard.rb has a syntax error, it should just warn and still load what it can.

[root@mypuppetmaster dev]# puppet help config
/usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require': /usr/local/dev/interface-utils/lib/puppet/face/dashboard.rb:10: syntax error (SyntaxError)
      parser = Puppet::[:parser, :current]
                        ^   from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    from /usr/local/dev/puppet//lib/puppet/interface/face_collection.rb:91:in `load_face'
    from /usr/local/dev/puppet//lib/puppet/interface/face_collection.rb:69:in `[]'
    from /usr/local/dev/puppet//lib/puppet/interface.rb:49:in `face?'
    from /usr/local/dev/puppet//lib/puppet/face/help.rb:105:in `legacy_applications'
    from /usr/local/dev/puppet//lib/puppet/face/help.rb:104:in `reject'
    from /usr/local/dev/puppet//lib/puppet/face/help.rb:104:in `legacy_applications'
    from /usr/local/dev/puppet//lib/puppet/face/help.rb:66:in `help implementation, required on Ruby 1.8'
     ... 8 levels...
    from /usr/local/dev/puppet//lib/puppet/application.rb:402:in `exit_on_fail'
    from /usr/local/dev/puppet//lib/puppet/application.rb:307:in `run'
    from /usr/local/dev/puppet//lib/puppet/util/command_line.rb:62:in `execute'
    from /usr/local/dev/puppet//bin/puppet:4

History

#1 Updated by Daniel Pittman almost 3 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Daniel Pittman
  • Target version set to 2.7.x
  • Affected Puppet version set to 2.7.0rc1

#2 Updated by Daniel Pittman almost 3 years ago

  • Status changed from Accepted to Merged - Pending Release

https://github.com/puppetlabs/puppet/compare/a71bfa1…d4df6cc merges this into 2.7.x

#3 Updated by James Turnbull almost 3 years ago

  • Status changed from Merged - Pending Release to Closed
  • Target version changed from 2.7.x to 2.7.0

#4 Updated by Daniel Pittman 11 months ago

  • Assignee deleted (Daniel Pittman)

Also available in: Atom PDF