Feature #7509

Better feedback during install action

Added by Daniel Pittman about 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:05/12/2011
Priority:NormalDue date:
Assignee:Jeff McCune% Done:

0%

Category:cloudpackSpent time:1.00 hour
Target version:0.6.0
Keywords: Roadmapped:No
Branch:

Description

The current feedback during the bootstrap process, especially for EC2, is not great. We want to give more, faster, feedback to the user while the face is doing its thing, especially when that thing is sitting about for five minutes waiting for Amazon to do their thang.

Related issues

Related to Cloud-Provisioner - Feature #8204: CloudPack should install PE from S3 not an SSH upload Closed 07/01/2011

History

#1 Updated by Jeff McCune almost 2 years ago

  • Project changed from Puppet Labs Modules to Cloud-Provisioner

#2 Updated by Jeff McCune almost 2 years ago

  • Roadmapped set to No

Additional Information

The upload process is lengthy, especially if using the “full” payload for PE.

➜ cloudpack git:(master) ✗ puppet node install --login=root \
  --keyfile=${keyfile} \
  --installer-payload=${installer_payload} \
  --installer-answers=${installer_answers} \
  ec2-204-236-252-190.compute-1.amazonaws.com
Waiting for SSH response ... Done
Uploading Puppet ...

#3 Updated by Jeff McCune almost 2 years ago

Nice to have for release

Dan and I believe this is a “nice to have” for release, but not required.

#4 Updated by Jeff McCune almost 2 years ago

  • Target version set to 0.6.0

#5 Updated by Nigel Kersten almost 2 years ago

  • Category set to cloudpack

#6 Updated by Jeff McCune almost 2 years ago

Note

This is so closely related to #8204 that if that ticket gets merged in, the sample install action output should be evaluated as satisfying this ticket or not.

#7 Updated by Jeff McCune almost 2 years ago

  • Status changed from Accepted to Merged - Pending Release
  • Assignee set to Jeff McCune

Merged

This functionality is provided in the Puppet::CloudPack#ssh_remote_execute method.

Standard output of the remote command is buffered and displayed line by line using Puppet.debug()

Merged as:

commit 71c44486f2a50a36553867f99d94147fa396eed1
Author: Jeff McCune 
Date:   Fri Jul 15 15:20:42 2011 -0700

    (#8204) Refactor ssh execute method
    
    This change moves all SSH executions into a new method called
    ssh_remote_execute.  This method uses Net::SSH directly and configures a
    callback to read data from the standard output of the remotely executing
    command.
    
    As data is received, we buffer the data until a newline is available
    then use Puppet.debug() to display the output to the end user as early
    as possible.  This provides a nice compromise between long running
    commands with no feedback and spamming the user with chopped up lines as
    it streams back using Puppet.debug.
    
    The spec tests have been adjusted to mock the calls wrapping the
    Net::SSH and Fog::SSH, Fog::SCP methods.
    
    Reviewed-by: Dan Bode

#8 Updated by Jeff McCune almost 2 years ago

  • Status changed from Merged - Pending Release to Closed

Also available in: Atom PDF