Puppet

It looks like there are 2-3 places that throw an exception, and at most one of them should.

I also recommend, for clarity, that FileParsing just be merged into ParsedFile – no other class uses it, and I think part of the confusion of ParsedFile is just that half of its functionality is in another file.

Anyway, I think this method:

  # Split a bunch of text into lines and then parse them individually.
  def parse(text)
    count = 1
    lines(text).collect do |line|
      count += 1
      if val = parse_line(line)
        val
      else
        error = Puppet::Error.new("Could not parse line #{line.inspect}")
        error.line = count
        raise error
      end
    end
  end

Should probably be changed to something like:

  def parse(text)
    count = 1
    lines(text).collect do |line|
      count += 1
      begin
        if val = parse_line(line)
          val
        else
          Puppet.warning "Could not parse invalid line #{line.inspect}"
          next
        end
      rescue => detail
        Puppet.warning "Could not parse invalid line #{line.inspect}: #{detail}"
        next
      end
    end.compact # remove nil values resulting from 'next'
  end

Note that this has the side effect of actually discarding bad (according to Puppet) lines, and I think it will do so even in noop mode. It’s worth making sure that ParsedFile doesn’t even write if global noop mode is enabled.