Bug #8374

MacPorts package provider should ignore warnings from the "port" command

Added by Matthias Pigulla almost 2 years ago. Updated 9 months ago.

Status:ClosedStart date:07/12/2011
Priority:NormalDue date:
Assignee:Matthias Pigulla% Done:

0%

Category:provider
Target version:3.0.0
Affected Puppet version: Branch:
Keywords:macports provider

Description

The “port” command may emit warnings, for example when a “portarchivepath” has been set that points to an unreachable network share.

The macports provider fails to recognize these warnings, mistaking them f.e. for the latest version number.

I have too little Ruby skills to get a redirection (stderr to /dev/null) working, so the attached patch simply filters out the warnings.

macports.patch Magnifier (1014 Bytes) Matthias Pigulla, 07/12/2011 06:25 am

History

#1 Updated by Matthias Pigulla almost 2 years ago

The patch also contains the change from #8319

#2 Updated by James Turnbull almost 2 years ago

  • Status changed from Unreviewed to Requires CLA to be signed
  • Assignee set to Matthias Pigulla

Hi Matthias

Could you sign the CLA at https://projects.puppetlabs.com/contributor_licenses/sign please?

Also it’d be great if you could submit this as a Git branch or a GitHub pull request as explained at https://github.com/puppetlabs/puppet/blob/master/CONTRIBUTING.md – thanks again for your contribution!

#3 Updated by Matthias Pigulla almost 2 years ago

Done – https://github.com/puppetlabs/puppet/pull/55

This is the first time I did this so I hope it’s allright…

#4 Updated by James Turnbull almost 2 years ago

  • Status changed from Requires CLA to be signed to In Topic Branch Pending Review
  • Target version set to 2.7.x

#5 Updated by Jacob Helwig almost 2 years ago

  • Status changed from In Topic Branch Pending Review to Tests Insufficient

Added some comments on the pull request about splitting the commit based on the ticket, adding some testing, and a better way to discard the warning lines.

#6 Updated by Matthias Pigulla almost 2 years ago

New pull req is https://github.com/puppetlabs/puppet/pull/57

#7 Updated by Patrick Carlisle over 1 year ago

  • Status changed from Tests Insufficient to Merged - Pending Release
  • Target version changed from 2.7.x to 3.x

Merged in commit:a52eb6ecaa8dca06639c60f05f3204eefdb4d482

(#8374) Make MacPorts provider ignore warnings from port command

#8 Updated by Daniel Pittman about 1 year ago

  • Target version changed from 3.x to 3.0.0

#9 Updated by Matthaus Owens 9 months ago

  • Status changed from Merged - Pending Release to Closed

Released in Puppet 3.0.0rc1

Also available in: Atom PDF