The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Refactor #8758

Yumrepo should be refactored to use a provider

Added by Luke Kanies over 3 years ago. Updated about 1 year ago.

Status:In Topic Branch Pending ReviewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:yumrepo
Target version:3.5.0
Affected Puppet version: Branch:https://github.com/puppetlabs/puppet/pull/2086
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This ticket is now tracked at: https://tickets.puppetlabs.com/browse/PUP-789


Description

The current implementation of Yumrepo has all of the work done directly in the type, rather than using a provider.

We should instead refactor it to use a provider, which should also make the code cleaner and easier to maintain.

I’ve got a patch that does at least a bit of this, but I never got it to production.

yumrepo_refactor.patch Magnifier - Patch that adds provider for yumrepo (11.1 KB) Luke Kanies, 08/03/2011 10:05 am


Related issues

Related to Puppet - Bug #9410: yumrepo type does notice changes Duplicate
Related to Puppet - Bug #17832: @yumrepo does not create a virtual resource Duplicate
Related to Puppet - Feature #9293: yum repos should be ensurable. In Topic Branch Pending Review
Related to Puppet - Bug #1238: Due to prefetching, Yumrepo clobbers any definition that ... Accepted

History

#1 Updated by James Turnbull over 3 years ago

  • Status changed from Accepted to In Topic Branch Pending Review

#2 Updated by James Turnbull over 3 years ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient
  • Assignee set to Luke Kanies

Luke – no longer applies cleanly to master.

#3 Updated by Luke Kanies about 3 years ago

Re-merged into a branch again:

https://github.com/lak/puppet/tree/ticket/master/8758-yumrepo_with_provider

#4 Updated by Luke Kanies about 3 years ago

  • Assignee changed from Luke Kanies to James Turnbull

#5 Updated by James Turnbull almost 3 years ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review
  • Assignee changed from James Turnbull to Anonymous
  • Branch set to https://github.com/lak/puppet/tree/ticket/master/8758-yumrepo_with_provider

#6 Updated by Luke Kanies over 2 years ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient
  • Assignee deleted (Anonymous)

Well, I just tried to turn my patch into a pull request, and it failed. The code seems to have changed too much, or maybe my code was all broken in the first place. I can’t get the tests to pass or anything.

It’s still a problem, IMO, but not as urgent given the lack of working code.

#7 Updated by eric sorenson almost 2 years ago

  • Target version set to 3.x

Relating a couple of bugs that have come up more recently— not having this split means you can’t use virtual yumrepo resources and it is not ensurable.

There is code attached in #9293.

#8 Updated by Anonymous about 1 year ago

https://github.com/puppetlabs/puppet/pull/2086 is an initial stab at this separation.

#9 Updated by Charlie Sharpsteen about 1 year ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review
  • Start date deleted (08/03/2011)
  • Branch changed from https://github.com/lak/puppet/tree/ticket/master/8758-yumrepo_with_provider to https://github.com/puppetlabs/puppet/pull/2086

#10 Updated by eric sorenson about 1 year ago

  • Target version changed from 3.x to 3.5.0

We’ll pull this in for the 3.5.0 timeframe.

Also available in: Atom PDF