Bug #9435

Feature #8268: Basic Puppet agent support on Windows

Log destinations are broken on Windows

Added by Josh Cooper 8 months ago. Updated 8 months ago.

Status:Closed Start date:09/12/2011
Priority:Normal Due date:
Assignee:Josh Cooper % Done:

100%

Category:windows
Target version:2.7.6 Estimated time:8.00 hours
Affected Puppet version:development Branch:
Keywords:
Votes: 0

Description

If no logging destination is set, puppet agent will attempt to add the syslog log destination, but this feature is not available on Windows and this generates an error (though puppet continues running):

c:/ruby187/lib/ruby/site_ruby/1.8/puppet/util/log/destinations.rb:7:in `initialize'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/util/log.rb:129:in `new'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/util/log.rb:129:in `newdestination'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/application/agent.rb:380:in `setup_logs'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/application/agent.rb:422:in `setup'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/application.rb:304:in `run'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/application.rb:410:in `hook'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/application.rb:304:in `run'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/application.rb:401:in `exit_on_fail'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/application.rb:304:in `run'
c:/ruby187/lib/ruby/site_ruby/1.8/puppet/util/command_line.rb:69:in `execute'
c:/ruby187/bin/puppet:4

If a file destination is specified, e.g. puppet agent —logdest=c:\log.txt, puppet doesn’t log to the file, because the file log destination only “match"es paths that start with ‘/’:

Puppet::Util::Log.newdesttype :file do
  match(/^\//)

History

Updated by Josh Cooper 8 months ago

  • Description updated (diff)

Updated by Josh Cooper 8 months ago

  • Status changed from Accepted to In Topic Branch Pending Review

Changes are ready to be merged at: https://github.com/puppetlabs/puppet/pull/108 https://github.com/puppetlabs/puppet/pull/109

Updated by Josh Cooper 8 months ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • % Done changed from 0 to 100

This was merged into 2.7.x in https://github.com/puppetlabs/puppet/commit/8c2dd75b5dc5e36d3f9697b049bd2427e1dd1351

Updated by James Turnbull 8 months ago

Should this have a target version if it’s merged?

Updated by Josh Cooper 8 months ago

  • Target version changed from 2.7.x to 2.7.5

Updated by Michael Stahnke 8 months ago

  • Status changed from Merged - Pending Release to Closed
  • Target version changed from 2.7.5 to 2.7.6

Released in 2.7.6rc1.

Also available in: Atom PDF