Feature #9879

Puppet resource hash support

Added by Nan Liu over 1 year ago. Updated over 1 year ago.

Status:ClosedStart date:10/04/2011
Priority:NormalDue date:
Assignee:Nan Liu% Done:

0%

Category:ralsh
Target version:-
Affected Puppet version:2.7.4 Branch:
Keywords:puppet resource, hash

Description

Improve puppet resource hash display.

Current:

type { 'title':
  attribute => hashkeyhashvalue,
}

New:

f5_monitor { 'https_443':
  ensure                    => 'present',
  manual_resume_state       => 'STATE_DISABLED',
  template_destination      => '*:443',
  template_integer_property => { ITYPE_TIME_UNTIL_UP       => '0',
                                 ITYPE_UP_INTERVAL         => '0',
                                 ITYPE_PROBE_TIMEOUT       => '0',
                                 ITYPE_UNSET               => '0',
                                 ITYPE_PROBE_INTERVAL      => '0',
                                 ITYPE_INTERVAL            => '5',
                                 ITYPE_PROBE_NUM_SUCCESSES => '0',
                                 ITYPE_PROBE_NUM_PROBES    => '0',
                                 ITYPE_TIMEOUT             => '16' },
  template_state            => 'STATE_ENABLED',
  template_string_property  => { STYPE_CLIENT_CERTIFICATE => '',
                                 STYPE_CIPHER_LIST        => 'DEFAULT:+SHA:+3DES:+kEDH',
                                 STYPE_SSL_OPTIONS        => 'enabled',
                                 STYPE_RECEIVE            => '',
                                 STYPE_PASSWORD           => '',
                                 STYPE_SEND               => 'GET /',
                                 STYPE_CLIENT_KEY         => '',
                                 STYPE_USERNAME           => '' },
  template_transparent_mode => 'false',
}

History

#1 Updated by Nan Liu over 1 year ago

  • Description updated (diff)

Pull request available at:

https://github.com/puppetlabs/puppet/pull/154

#2 Updated by Nan Liu over 1 year ago

Apparently Jacob have a patch for #8414 that solves this from another angle: 23d5aeb

I prefer this output because I think it’s a bit more readable, but I don’t know if there are other implications and I’ll leave this up to engineering to decide whether to not to accept/merge.

#3 Updated by Jacob Helwig over 1 year ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient

Nan,

I do like the output you have for ‘puppet resource’ better. The branch you have right now no longer works since I unified the formatting of parameter values to a class method on Puppet::Parameter. I could see adding an options hash to this method to support both multi-line output, and the single line output necessary for logging/reporting. Something like Puppet::Parameter.format_value_for_display(v, :multi_line_hashes => true).

I would like to see this feature go on. Any chance you might have time to make the needed updates?

#4 Updated by Nan Liu over 1 year ago

Yeah, I’ll take another shot at this over this weekend since it’s very helpful for the current project I’m working on.

#5 Updated by Daniel Pittman over 1 year ago

  • Assignee set to Nan Liu

Nan Liu wrote:

Yeah, I’ll take another shot at this over this weekend since it’s very helpful for the current project I’m working on.

Hey. I wanted to follow up on this with you and see where it was up to?

#6 Updated by Nan Liu over 1 year ago

  • Status changed from Code Insufficient to Closed

I’m going to close this for now since I haven’t had time to visit this in a while.

#7 Updated by Daniel Pittman over 1 year ago

  • Target version deleted (2.7.x)

Also available in: Atom PDF