Bug #8435

openbsd package provider is broken while installing from remote repositories

Added by Peter Meier 10 months ago. Updated 3 months ago.

Status:Closed Start date:07/15/2011
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:package
Target version:2.7.12
Affected Puppet version:2.6.3 Branch:https://github.com/puppetlabs/puppet/pull/452
Keywords:openbsd
Votes: 1

Description

  1. Introduced by 4a3d5d7c11bea5efba6f PATH_SEPARATOR openbsd package provider checks for PATH_SEPARATOR however this should be SEPARATOR –> Installing packages from a remote source does not work
  2. Also introduced by this commit the package provider tries to get the current installed version and checks whether it should be updated. However this fails if the package hasn’t yet been installed.

Although I’m not (yet) fully sure about the intend of this commit I will send some Patches with which I got package installation on openbsd from a remote repository working.

I add Markus as a watcher as he submitted the patch.

Related issues

related to Puppet - Bug #9651: OpenBSD Package provider is fubar'd Investigating 09/22/2011
blocked by Puppet - Bug #12564: The execution helper method `execpipe` has a different AP... Closed 02/10/2012

History

#1
Updated by Michael Stahnke 10 months ago

  • Affected Puppet version changed from 2.7.2rc1 to 2.6.3
  • Keywords set to openbsd

This looks like it has been a problem since 2.6.3

git tag —contains 4a3d5d7c11bea5efba6f

We certainly agree it’s a problem, but does not block the release of 2.7.2.

#2
Updated by Michael Stahnke 10 months ago

  • Status changed from Unreviewed to Accepted

#3
Updated by Peter Meier 10 months ago

  • Branch set to https://github.com/duritong/puppet/tree/ticket/master/8435

Pushed a possible fix to be discussed: https://github.com/duritong/puppet/tree/ticket/master/8435

#4
Updated by Peter Meier 7 months ago

What’s the current status of this review?

As I said, if somebody could comment about the correctness of this approach I would probably be able to work on proper tests etc. But the longer this fades away the more complicated it is to get back into the context.

Reminder: This means that remote package installation on OpenBSD is currently not working, hence I think it would be quite important to get that fixed.

#5
Updated by Jacob Helwig 6 months ago

  • Status changed from Accepted to Tests Insufficient
  • Target version set to 2.7.x

I left a couple of comments on the pull request, but your last update on the pull request summarizes things nicely:

So after some discussion on IRC we settled with the following:

* This patch should be rebased agains 2.7.x
* It should get a proper commit message
* Tests would be nice, however as for the openbsd provider tests are missing in general, we have to see what is possible.

This means that in general the approach seems feasible and we just need to do some cleanup.

#6
Updated by Jacob Helwig 6 months ago

The pull request in question is number 20

#7
Updated by Joe McDonagh 6 months ago

The whole provider needs to be thrown out in favor of Mtier’s provider IMO. Some of it remains similar but I have been testing Mtier’s provider with a slight modification for proper flavors, attached to 9651.

#8
Updated by warm s0x 5 months ago

I was wondering if there was a build of puppet running around between various patch sets that solves this problem?

Unfortunately I recently started a project in which I’ll need to rely on remote package functionality. This bug has kind of stopped me in my tracks :(

#9
Updated by Daniel Pittman 4 months ago

  • Status changed from Tests Insufficient to In Topic Branch Pending Review
  • Branch changed from https://github.com/duritong/puppet/tree/ticket/master/8435 to https://github.com/puppetlabs/puppet/pull/452

https://github.com/puppetlabs/puppet/pull/452 is an update that adds tests to the provider, and should hopefully have the bug fixed and things ready to go. Testing would be appreciated from anyone using OpenBSD, of course.

#10
Updated by Daniel Pittman 3 months ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient

My whitespace cleanup ends up breaking things because the API for execpipe is different from execute – the later adds whitespace between array elements, while the former expects the caller to add whitespace. #12564 captures that, and I am going to fix the underlying bug so that this change works – and other people don’t suffer the same headache around the execution helper API there.

#11
Updated by Daniel Pittman 3 months ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review

Code fixing the issue is now in the pull request, ready for review and merge.

#12
Updated by Daniel Pittman 3 months ago

  • Status changed from In Topic Branch Pending Review to Accepted

#13
Updated by Daniel Pittman 3 months ago

  • Status changed from Accepted to In Topic Branch Pending Review

#14
Updated by Daniel Pittman 3 months ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version changed from 2.7.x to 2.7.12

#15
Updated by Matthaus Litteken 3 months ago

  • Status changed from Merged - Pending Release to Closed

Released in 2.7.12rc1

Also available in: Atom PDF