The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Activity

From 10/22/2008 to 10/28/2008

10/29/2008

11:43 pm Bug #1669: Mount parameter "dump" doesn't work
If you change... Oliver Hookins
11:34 pm Bug #1669: Mount parameter "dump" doesn't work
With my mountain of ruby experience (hah), I've determined that the issue lies at line 146 of lib/puppet/type/mount.r... Oliver Hookins
11:06 pm Bug #1641 (Closed): REST file recursion behaves differently on subsequent runs than on first run
Fixed in commit:53320346a87185f945694acda9ee4e58e612d0bf in my repo. It'll be merged and uploaded as soon as all of ... Luke Kanies
11:03 pm Bug #1702 (Accepted): SELinux code inefficiently makes syscalls to stat and matchpathcon
James Turnbull
10:54 pm Feature #1402 (Code Insufficient): multi-line comments
James Turnbull
10:54 pm Bug #857 (Code Insufficient): Behaviour of Puppet when multiple classes of the same name are defined
James Turnbull
10:54 pm Bug #1682 (Closed): Array variables not properly flattened
Pushed in commit:c7ccc4ba7c42d56595564491ae578a1604c628d1 in branch 0.24.x James Turnbull
10:28 pm Feature #1667 (Closed): Documentation should specify natural language regexs, not Regexp objects
Pushed in commit:c906afd9e36017bba339ca50998e1651e54dbd0c in branch 0.24.x James Turnbull
10:23 pm Bug #1688: puppetca can't clean unsigned certs
jamtur01 wrote:
> It's the same issue - it's no the FQDN that's the problem - it's the unsigned state. Try to sign ...
Peter Meier
10:21 pm Bug #1688: puppetca can't clean unsigned certs
It's the same issue - it's no the FQDN that's the problem - it's the unsigned state. Try to sign the cert and then y... James Turnbull
10:15 pm Bug #1688: puppetca can't clean unsigned certs
This may be a different issue, but I found that I could not clean a cert that does not have a proper FQDN:... micah -
10:14 pm Feature #1667 (Ready For Checkin): Documentation should specify natural language regexs, not Rege...
Fixed in the tickets/0.24.x/1667 branch in my repo.
No tests, since this is a purely text-based fix.
Luke Kanies
10:03 pm Bug #1709 (Closed): Using ldap provider on user and group types hangs puppetd on next run when ld...
h1. Environment
The puppet nodes are using some local accounts, and some LDAP accounts.
The "user" and "group" ty...
Stig Sandbeck Mathisen
09:57 pm Feature #1701: File type should be configurable to affect only files, or only directories, or both
Hmm yes... damn. I don't have a nice solution for that unfortunately, unless we were to implement a directory type li... Oliver Hookins
09:47 pm Bug #1683: Settings should not replace current values until new values are available
Ah, ok that makes sense. My rollout procedure actually rsyncs over the puppet.conf from the staging server then uses ... Oliver Hookins
09:37 pm Feature #1667: Documentation should specify natural language regexs, not Regexp objects
... Matt Palmer
09:15 pm Bug #1705 (Rejected): AST::ASTArray needs to check for empty elements as well as nil elements whe...
Even if you were to delete empty strings from the array, you'd need to do ... Luke Kanies
09:12 pm Bug #1704 (Accepted): report delivery succeeds even though puppetd thinks it fails
Wow. Um. I don't really know how to deal with this -- the problem is that the client is not seeing an 'ok' result, ... Luke Kanies
09:11 pm Bug #1703 (Accepted): Thread error in tagmail
I'm assuming that some part of Ruby is requiring that we lock the thread we're in before we use IO.popen, or somethin... Luke Kanies
09:09 pm Feature #1701 (Needs More Information): File type should be configurable to affect only files, or...
Note that doing this, given the current limitations of Puppet's uniqueness requirements, would mean that you couldn't... Luke Kanies
09:07 pm Bug #1708 (Accepted): Strange behavior from the user provider in 0.24.6
I expect this is a result of the work I did to fix the problems with group information apparently being cached.
It...
Luke Kanies
08:18 pm Bug #1708 (Closed): Strange behavior from the user provider in 0.24.6
This is in RHEL4. Output from Tenshi log after running a test of 0.24.6 against our config:
1: usermod info us...
Sam Rowe
07:02 pm Bug #1705: AST::ASTArray needs to check for empty elements as well as nil elements when flattening
Or use the more compact Array#compact:... Jos Backus
05:39 pm Feature #1706 (Needs Decision): Puppet should use IO#tty? to determine default for colorization
I don't really like this idea (as mentioned on IRC), because there are plenty of times where I don't have a tty but s... Luke Kanies

10/28/2008

03:36 pm Feature #1707 (Rejected): Mutably append to variables given an absolute scope
Puppet uses relative scope for simplicity. This is useful in making sure that modules don't inadvertently step on var... Jeff Goldschrafe
03:35 pm Feature #1706 (Closed): Puppet should use IO#tty? to determine default for colorization
Puppet should use the IO#tty? to set the default value for colorized output.
I'd be glad to implement this, if it'...
Clayton O'Neill
01:50 pm Bug #1705 (Rejected): AST::ASTArray needs to check for empty elements as well as nil elements whe...
This manifest:
#!/usr/bin/env puppet
$groups = ["foo", "bar", ""]
$groups2 = ["baz", "quux"]
$u...
Ryan Steele
01:27 pm Bug #1682: Array variables not properly flattened
I tested this, and it works on 0.24.6. Nice job, Brice. Ryan Steele
01:18 pm Bug #1682: Array variables not properly flattened
Oops, I meant "ready for testing", but instead chose "ready for checking".
The patch didn't get any review yet, can ...
Brice Figureau
01:07 pm Bug #1704 (Closed): report delivery succeeds even though puppetd thinks it fails
When puppetd delivers the report to puppetmasterd it sometimes thinks the delivery failed even though it succeeded. I... Martin Englund
12:50 pm Bug #1703 (Closed): Thread error in tagmail
I've just upgraded to puppet 0.24.6 (using Ruby 1.8.7 p72 on Solaris 10 x86) from 0.24.5 and it gives me the followin... Martin Englund
12:35 pm Bug #1682 (Ready For Checkin): Array variables not properly flattened
AST::ASTArray lacks of a final flatten after evaluating its children.
This is fixed in branch tickets/0.24.x/1682 ...
Brice Figureau
12:14 pm Bug #1683 (Accepted): Settings should not replace current values until new values are available
Awesome, thanks.
Puppet is convinced that your puppet.conf needs reparsing, which means that the timestamp on disk...
Luke Kanies
12:10 pm Feature #1700 (Duplicate): Recursive file copies touching unmanaged files should be optional, not...
Yeah, this is a duplicate of #1469. Luke Kanies
10:59 am Bug #1691 (Duplicate): Realization fails if variable is used to represent array OR multiple reali...
rgsteele wrote:
> Manifest that fails
>
> $foo = ["bar", "baz"]
> realize( Group[$foo] )
>
> Failure ou...
Brice Figureau
09:05 am Bug #857 (Ready For Checkin): Behaviour of Puppet when multiple classes of the same name are defined
Hi James,
Rebased against current 0.24.x. It seems to apply fine above #1402.
It is still in the tickets/0.24.x/8...
Brice Figureau
08:35 am Feature #1402 (Ready For Checkin): multi-line comments
Hi James,
It is now freshly rebased. And still in the tickets/0.24.x/1402 branch of my github repository:
http://...
Brice Figureau
06:15 am Bug #1683: Settings should not replace current values until new values are available
OK, I did a simple Puppet.settings.freeze and it did provide a traceback, let me know if you want me to try again wit... Oliver Hookins
05:51 am Bug #1702 (Closed): SELinux code inefficiently makes syscalls to stat and matchpathcon
... Oliver Hookins
05:12 am Feature #1701 (Rejected): File type should be configurable to affect only files, or only director...
Currently the file type will affect files and directories indeterminately, (e.g. if setting permissions recursively).... Oliver Hookins
05:06 am Feature #1700 (Duplicate): Recursive file copies touching unmanaged files should be optional, not...
When doing a recursive copy from a fileserver, you may want to copy and set permissions on a bunch of files in the di... Oliver Hookins
05:04 am Bug #1666 (Accepted): file parameter "recurse => 1" is broken
James Turnbull
05:03 am Bug #1669 (Accepted): Mount parameter "dump" doesn't work
James Turnbull
05:03 am Bug #1682 (Accepted): Array variables not properly flattened
James Turnbull
04:57 am Bug #1692 (Closed): k5login fails to set mode when file is created
Pushed in commit:e542f8c6fbfb5ae5eead9d5744667bd6840159f7 in branch 0.24.x James Turnbull
04:54 am Feature #1668: Additional features for the file type
With #2, currently it is not possible to set files within the directory to be read-only, but leave sub-directories wi... Oliver Hookins
04:50 am Bug #1660 (Closed): tidy recurse section of documentation should list valid values
Pushed in commit:57e791b9e7da931e61dd8dfc0f68bd13cf2e6449 in branch 0.24.x James Turnbull
04:44 am Bug #1698 (Closed): err priority log items are no longer logged to the master
Pushed in commit:42cac73a7ce531e125c1c94f7bd942d9002e5445 in branch 0.24.x James Turnbull
04:41 am Feature #1668 (Rejected): Additional features for the file type
Please open these as separate tickets.
I'm nearly positive #1 is already open, and #2 has already been opened and ...
Luke Kanies
04:40 am Feature #1671 (Rejected): Yum should remove packages causing dependency issues
Destructive actions like this, without an easy way to revert, will always require intervention from the user. Luke Kanies
04:38 am Bug #1660 (Ready For Checkin): tidy recurse section of documentation should list valid values
Yeah, all of the recursion code is directly inherited from 'file', so 'tidy' should just have a 'newvalue' call added... Luke Kanies
04:34 am Refactor #1638: Generate CHANGELOG file at release time to minimize conflicts when merging (and s...
Sample rake task I am going to steal:... James Turnbull
04:24 am Bug #1699 (Rejected): Can't generate peer certificate
The server needs to be as current as the client, and in this case, the client only knows how to talk REST, not xmlrpc... Luke Kanies
04:22 am Bug #1698 (Ready For Checkin): err priority log items are no longer logged to the master
This must be because of the refactoring of the Log class I did.
I didn't actually think these logs would ever have...
Luke Kanies
04:16 am Bug #1660 (Needs More Information): tidy recurse section of documentation should list valid values
James Turnbull
04:16 am Bug #1660 (Needs Decision): tidy recurse section of documentation should list valid values
Luke - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=500848
Can you confirm the behaviour of tidy recurse versu...
James Turnbull
03:49 am Bug #1661 (Closed): Type reference: tidy should specify manditory parameters
Pushed in commit:6ab4f1b0e2a3f5881d865ca181c053c64d5026a7 in branch 0.24.x James Turnbull
03:45 am Feature #1668 (Needs Decision): Additional features for the file type
James Turnbull
03:45 am Feature #1671 (Needs Decision): Yum should remove packages causing dependency issues
James Turnbull
03:44 am Bug #1699 (Accepted): Can't generate peer certificate
James Turnbull
03:42 am Bug #1684 (Needs More Information): puppetmasterd fails assertion when log directory doesn't alre...
Can you provide a run with --verbose --debug --trace enabled please. James Turnbull
03:40 am Bug #1691 (Accepted): Realization fails if variable is used to represent array OR multiple realiz...
Brice - can I ask you throw your eyes over this? Let me know if you don't have time or would prefer not. Thanks. James Turnbull
03:09 am Facter Bug #1697 (Closed): Typo in ipaddress.rb causes timeout under Solaris 10 SPARC
Merged. Luke Kanies
03:09 am Bug #1683: Settings should not replace current values until new values are available
As indicated, I think this is related to #1143, but that ticket shows the settings losing their values entirely, rath... Luke Kanies
02:43 am Refactor #1693 (Closed): All mentions of EPM should be removed from Rakefile and build library
Pushed in commit:2459106673f992df7f00be4d9f56957f4b6ba9e0 in branch 0.24.x James Turnbull
02:01 am Bug #1683: Settings should not replace current values until new values are available
Oh, if it makes any difference, both my staging and live puppetmasters are running on RHEL5 i386. Oliver Hookins
01:44 am Bug #1699 (Closed): Can't generate peer certificate
Puppetmaster and puppet client are running 0.25. Puppetca server is running 0.24.4.
Branch is checked out from:
...
Victor Chavez
01:22 am Bug #1698 (Closed): err priority log items are no longer logged to the master
After upgrading, I've noticed err priority log messages from puppetd aren't making their way to the master.
For ex...
Oliver Hookins
12:54 am Facter Bug #1697 (Ready For Checkin): Typo in ipaddress.rb causes timeout under Solaris 10 SPARC
Pushed in commit:43d0aeadbd003fa6b0787084d77e86f48e5dab1d in my master. James Turnbull
12:52 am Bug #857 (Code Insufficient): Behaviour of Puppet when multiple classes of the same name are defined
Can you please rebase to the current 0.24.x James Turnbull
12:50 am Feature #1104 (Closed): Classes and nodes should set $name variables
Pushed in commit:9ecbd6306d227189ba161954aafc3e7f782a87b9 in branch 0.24.x James Turnbull
12:47 am Feature #1402 (Tests Insufficient): multi-line comments
Brice - can you please rebase this off the current 0.24.x please. James Turnbull
12:32 am Facter Bug #1697 (Closed): Typo in ipaddress.rb causes timeout under Solaris 10 SPARC
Simple problem, simple solution.
In ipaddress.rb:...
Josh Anderson
11:55 pm Bug #1683: Settings should not replace current values until new values are available
puppet.conf on the puppetmaster is very stable - it is rolled out as is from my svn repo by rsync so rarely if ever g... Oliver Hookins
11:40 pm Feature #1696 (Accepted): Add support for branded zones
James Turnbull
11:38 pm Feature #1696 (Closed): Add support for branded zones
This patch adds two new parameters on the zone type, and the backing
provider support. The parameters are create_ar...
Clayton O'Neill
11:38 pm Bug #1695 (Accepted): Solaris 10 zone provider doesn't properly handle unknown zone attributes in...
James Turnbull
11:36 pm Bug #1695 (Closed): Solaris 10 zone provider doesn't properly handle unknown zone attributes in n...
If you try to use the zone provider on newer versions of Solaris 10, it dies when it tries to pull in the zone config... Clayton O'Neill
08:58 pm Refactor #1694 (Closed): The rakefile system should be completely refactored
The existing system is pretty clunky, in that a lot of the rake tasks have to be dynamically generated because they h... Luke Kanies
08:52 pm Refactor #1693 (Ready For Checkin): All mentions of EPM should be removed from Rakefile and build...
Completed in tickets/0.24.x/1693 in my repo. Luke Kanies
08:38 pm Refactor #1693 (Closed): All mentions of EPM should be removed from Rakefile and build library
We haven't used EPM in a while, so it's just a confusing waste now. Luke Kanies
08:20 pm Bug #1692 (Accepted): k5login fails to set mode when file is created
James Turnbull
08:12 pm Bug #1692 (Closed): k5login fails to set mode when file is created
There is a small bug in the k5login type where setting the mode fails when the file is created.
Here is a diff of...
Grumpus the Cat
06:19 pm Bug #1691: Realization fails if variable is used to represent array OR multiple realizes exist in...
This kind of looks like #787 Ryan Steele
06:02 pm Bug #1691: Realization fails if variable is used to represent array OR multiple realizes exist in...
Interestingly, this also fails:
if $foo == "blah" {
realize( Groupcommit:"bar"] )
realize( Group["baz...
Ryan Steele
05:55 pm Bug #1691 (Duplicate): Realization fails if variable is used to represent array OR multiple reali...
Manifest that fails
$foo = ["bar", "baz"]
realize( Group[$foo] )
Failure output
err: Could not ret...
Ryan Steele

10/27/2008

04:28 pm Bug #1683 (Needs More Information): Settings should not replace current values until new values a...
Wow. So it looks like you're somehow losing all setting values when the manifests get reparsed? That's frightening.... Luke Kanies
04:24 pm Bug #1686 (Needs Decision): Class names containing '-' cannot be used to scope variables
Ugh. This is what I get for allowing '-' in the class names.
Should we change the variable names to support '-', ...
Luke Kanies
04:23 pm Bug #1690 (Rejected): Dependencies for class not preserved
The Puppet manifests are evaluated to generate a catalog, and only once the manifests are fully evaluated is any work... Luke Kanies
02:14 pm Bug #1690 (Rejected): Dependencies for class not preserved
I'm trying to install certain package before specific class is evaluated (see sample script). Unfortunately puppet do... Marcin Deranek
09:44 am Bug #1689 (Closed): Hundreds of log messages a second because of dns resolution
Hello,
I have a puppet installation with one master and around 20 clients.
The problem appeared until now twice, a...
Alexandru Ionica
09:21 am Bug #1680 (Accepted): Setting user password on Solaris does not work
James Turnbull
09:21 am Bug #1688 (Accepted): puppetca can't clean unsigned certs
James Turnbull
04:42 am Bug #1688 (Closed): puppetca can't clean unsigned certs
You cannot execute a:
* puppetca --clean wrong.hostname.com
if you erroneously send up an invalid certificate.
...
Mike Crowe
03:02 am Bug #1687 (Accepted): SELinux operations don't appear to be working on RHEL4
James Turnbull
02:47 am Bug #1687 (Closed): SELinux operations don't appear to be working on RHEL4
... Oliver Hookins
01:11 am Bug #1679: Control characters can't be used within a file resource
I found another issue, may be the same thing if Puppet is generally stripping out control characters from variables b... Oliver Hookins

10/25/2008

01:12 am Bug #1658: Gentoo package re-write
I'll see if I can get some time to test this, cause frankly eix is a pita to deal with.
I'd love to see this go in...
Ramon Alteren
07:01 pm Bug #1686 (Duplicate): Class names containing '-' cannot be used to scope variables
Class names containing '-' cause a parse error when used to specify variable scope.
Sample manifest:...
Josh Anderson
05:40 pm Bug #1685: filenames with ++ in their name are not handled properly
luke wrote:
> And I just tested this and can't reproduce it. Are you sure you're running 0.24.6 on the client and s...
micah -

10/24/2008

04:55 pm Bug #1685: filenames with ++ in their name are not handled properly
And I just tested this and can't reproduce it. Are you sure you're running 0.24.6 on the client and server? If you'... Luke Kanies
04:54 pm Bug #1596 (Closed): Deploying file resources with ++ in name generates error.
Closing again, since I can't reproduce. Luke Kanies
04:51 pm Bug #1596 (Re-opened): Deploying file resources with ++ in name generates error.
Luke Kanies
04:51 pm Bug #1685 (Duplicate): filenames with ++ in their name are not handled properly
This is a duplicate of #1596, which was theoretically fixed in 0.24.6. I'll reopen that. Luke Kanies
04:22 pm Bug #1685 (Duplicate): filenames with ++ in their name are not handled properly
When using the file type, if the path has a file that has a '++' in the name, puppet tries to parse it as a regexp.
...
micah -
08:39 am Bug #1684 (Closed): puppetmasterd fails assertion when log directory doesn't already exist and cl...
Using puppetmasterd straight out of RH EPEL under CentOS 5.2 with the ruby-ldap module
When I add a new machine to...
Mark Chappell
07:17 am Bug #1683 (Closed): Settings should not replace current values until new values are available
So far I haven't been able to figure out what this is caused by so indulge me if I don't have a complete picture of w... Oliver Hookins
03:55 am Bug #1682 (Closed): Array variables not properly flattened
These should output the same thing, but they do not. This is against the latest version as of today.
manifest ver...
Ryan Steele
11:19 pm Bug #1681: SELinux gets wrong seltype for NFS mounts
More info:
with default on the file and the mount point not mounted:
first puppetd run:
notice: //Node[nelson]/c...
Eric Eisenhart
11:17 pm Bug #1679 (Accepted): Control characters can't be used within a file resource
James Turnbull
11:17 pm Bug #1681 (Accepted): SELinux gets wrong seltype for NFS mounts
James Turnbull
10:39 pm Bug #1681 (Closed): SELinux gets wrong seltype for NFS mounts
This is on a system with SELinux in permissive mode.
puppet code looks like:
file { "nfs/jeckle/mail_admin": ensu...
Eric Eisenhart

10/23/2008

12:37 pm Bug #1680 (Closed): Setting user password on Solaris does not work
The user provider appears to use the -p parameter to useradd, to specify a crypted password to use for the user. On ... Clayton O'Neill
04:48 am Bug #1678 (Duplicate): Nameservice caching causes problems with changed groups/users during run
Duplicate of (closed) #791. Luke Kanies
04:28 am Bug #1678: Nameservice caching causes problems with changed groups/users during run
Actually, I'm not sure about the "sleep 5" making it work, I might have forgotten to remove the package on some test ... Oliver Hookins
03:42 am Bug #1679 (Closed): Control characters can't be used within a file resource
Our use case is thus: occasionally users will copy perl scripts over to our Linux machines from a Windows machine, un... Oliver Hookins
03:36 am Bug #1678 (Duplicate): Nameservice caching causes problems with changed groups/users during run
I have a package (osirisd) that creates a user and group (both osirisd). My package resource is depended on by a file... Oliver Hookins
11:33 pm Bug #1677 (Closed): SELinux tests fail in master
I get a bunch of failures from the spec tests in master:... Luke Kanies
11:15 pm Bug #1676 (Closed): Reloaded resource types lose their provider lists
When you reload a Puppet type, using 'require' or what have you, the new type has no providers because the provider l... Luke Kanies
11:14 pm Bug #1675 (Closed): Puppet's autoloader conflicts with Ruby's file loader
If you use Ruby to directly load a file that would normally be loaded by Puppet's autoloader, you can get some weird ... Luke Kanies
10:49 pm Bug #1674 (Accepted): String/array comparisons cause language failures
This is just a language problem: If you have a case or selector statement and you try to use both arrays and strings... Luke Kanies
10:46 pm Facter Bug #1650 (Closed): OS X package creation script should be more selective about cleaning out prio...
Merged. Luke Kanies
10:37 pm Bug #1674 (Rejected): String/array comparisons cause language failures
rgsteele wrote:
> After re-reading my configuration, I see the problem: I've got a define that accepts an argument "...
Luke Kanies
09:02 pm Bug #1663 (Closed): Regression relating to facter fact naming from 0.24.5
Pushed in commit:f21623735deaeb5cd4207a24983ab985f0f9e6af in branch 0.24.x James Turnbull
09:01 pm Bug #1673 (Closed): Regression in SELinux handling from 0.24.6rc1 to 0.24.6rc2
Pushed in commit:f7516a75d93b2fe97adea1b4296541be71ae5d9b and commit:81c3b721f7c2622d6145338dd28aa328fcf5af1a in bran... James Turnbull
06:39 pm Bug #1673 (Ready For Checkin): Regression in SELinux handling from 0.24.6rc1 to 0.24.6rc2
Fix in my 0.24.x/bug/1673 branch at github. Also includes fix to make tests pass when Puppet debug mode is enabled d... Sean Millichamp
05:52 pm Bug #1674: String/array comparisons cause language failures
After re-reading my configuration, I see the problem: I've got a define that accepts an argument "groups", which defa... Ryan Steele
05:44 pm Bug #1674: String/array comparisons cause language failures
Below are the classes and definitions used to reproduce this problem. And, according to the TypeReference, arrays ar... Ryan Steele

10/22/2008

04:48 pm Bug #1663 (Re-opened): Regression relating to facter fact naming from 0.24.5
The accepted patch doesn't include the protection from symbols in the patch from comment #4. I have re-added that co... Sean Millichamp
04:40 pm Bug #1674 (Accepted): String/array comparisons cause language failures

Can you include the puppet manifest that is throwing this?
The exception not being rescued is definitely an issu...
Andrew Shafer
03:17 pm Bug #1674 (Accepted): String/array comparisons cause language failures
If the 'groups' attribute for a user is first stored as a string, but then later changed to an array, Puppet throws a... Ryan Steele
10:56 am Facter Bug #1650 (Ready For Checkin): OS X package creation script should be more selective about cleani...
Pushed in commit:4e707c6b536f7c7ddaedaeb4dae84e3f898426e5 in branch master. James Turnbull
10:03 am Bug #1672: crontab update craps out in zones on Solaris 10
Some further digging revealed that the cause is when it calls "crontab -l" it fails, and since the below code assumes... Martin Englund
07:13 am Facter Feature #1634 (Closed): Update virtual fact to differentiate OpenVZ hardware nodes and virtual en...
Applied in changeset commit:6393e82e86def14891b204803aba156059736749. James Turnbull
03:31 am Bug #1673 (Closed): Regression in SELinux handling from 0.24.6rc1 to 0.24.6rc2
In the cleanup I did to fully specify path names I also adjusted it to be more "Puppet-like" and use the functions Pu... Sean Millichamp
 

Also available in: Atom