The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #11057

Better debugging output when skipping an agent/master run.

Added by Daniel Pittman over 2 years ago. Updated about 2 years ago.

Status:ClosedStart date:11/28/2011
Priority:NormalDue date:
Assignee:Chris Price% Done:

0%

Category:agent
Target version:2.7.12
Affected Puppet version: Branch:https://github.com/puppetlabs/puppet/pull/235
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

At the moment we will skip a run if the agent is waiting on a restart because of an external signal, etc. This is necessary because we have an inescapable race around signal handling in that regard.

Unfortunately, it was very opaque: there was no information about why the restart was skipped. This becomes more important when something else goes wrong and the only diagnostics we have are that we are skipping the scheduled run.


Related issues

Related to Puppet - Feature #3757: --enable and --disable should be improved Closed 05/12/2010

History

#1 Updated by Daniel Pittman over 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Target version changed from 2.7.8 to 2.7.x
  • Branch set to https://github.com/puppetlabs/puppet/pull/235

#2 Updated by Jeff McCune about 2 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version changed from 2.7.x to 2.7.10

Merged into 2.7.x

Merged into 2.7.x as https://github.com/puppetlabs/puppet/commit/e78dc4cfa7c3eeaba9c1c5115c51c8738ac6d46b

Build wasn’t broken, tests added, ticket updated.

#3 Updated by Jeff McCune about 2 years ago

  • Target version changed from 2.7.10 to 2.7.11

Targeting 2.7.11

Missed the 2.7.10rc1 by a few minutes so I’m re-targeting this at 2.7.11.

#4 Updated by Matthaus Owens about 2 years ago

  • Status changed from Merged - Pending Release to Closed
  • Target version changed from 2.7.11 to 2.7.12

Released in 2.7.12rc1

#5 Updated by Chris Price about 2 years ago

  • Status changed from Closed to Re-opened
  • Assignee changed from Daniel Pittman to Chris Price

The original fix for this has been reverted from 2.7.x because it depended on a commit that changed the behavior of puppet agent lockfiles. This could possibly be re-implemented w/o that commit, need feedback on whether or not that is something we want to try to squeeze into 2.7.12.

#6 Updated by Chris Price about 2 years ago

  • Status changed from Re-opened to Needs Decision
  • Assignee changed from Chris Price to Matthaus Owens

#7 Updated by Matthaus Owens about 2 years ago

  • Status changed from Needs Decision to Accepted
  • Assignee changed from Matthaus Owens to Chris Price

It sounds like this is just introspecting and changing an output message to be more accurate (i.e., no file content changes). If this is doable, it should get back into 2.7.12, but if not then it should still be fine for 2.7.x

#8 Updated by Chris Price about 2 years ago

I had this confused with #4836. #11057 was actually not affected at all by the activities surrounding #12844, so I’m closing this again.

#9 Updated by Chris Price about 2 years ago

  • Status changed from Accepted to Closed

Also available in: Atom PDF