The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com
Better debugging output when skipping an agent/master run.
|Assignee:||Chris Price||% Done:|
|Affected Puppet version:||Branch:||https://github.com/puppetlabs/puppet/pull/235|
Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com
At the moment we will skip a run if the agent is waiting on a restart because of an external signal, etc. This is necessary because we have an inescapable race around signal handling in that regard.
Unfortunately, it was very opaque: there was no information about why the restart was skipped. This becomes more important when something else goes wrong and the only diagnostics we have are that we are skipping the scheduled run.
#2 Updated by Jeff McCune about 3 years ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
- Target version changed from 2.7.x to 2.7.10
Merged into 2.7.x¶
Merged into 2.7.x as https://github.com/puppetlabs/puppet/commit/e78dc4cfa7c3eeaba9c1c5115c51c8738ac6d46b
Build wasn’t broken, tests added, ticket updated.
#5 Updated by Chris Price almost 3 years ago
- Status changed from Closed to Re-opened
- Assignee changed from Anonymous to Chris Price
The original fix for this has been reverted from 2.7.x because it depended on a commit that changed the behavior of puppet agent lockfiles. This could possibly be re-implemented w/o that commit, need feedback on whether or not that is something we want to try to squeeze into 2.7.12.
#7 Updated by Matthaus Owens almost 3 years ago
- Status changed from Needs Decision to Accepted
- Assignee changed from Matthaus Owens to Chris Price
It sounds like this is just introspecting and changing an output message to be more accurate (i.e., no file content changes). If this is doable, it should get back into 2.7.12, but if not then it should still be fine for 2.7.x