The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #11139

Bug #11138: Add a way to create versioned classes

change the core message wrapper to be JSON friendly

Added by R.I. Pienaar over 2 years ago. Updated about 2 years ago.

Status:AcceptedStart date:12/02/2011
Priority:NormalDue date:
Assignee:R.I. Pienaar% Done:

0%

Category:Core
Target version:2.1.x
Keywords: Affected mCollective version:
Branch:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This ticket may be automatically exported to the MCO project on JIRA using the button below:


Description

The main wrapper for messages as per Security::Base should not be using symbols but strings so that it’s easier to use from different languages and to eventually use JSON as a serializer

History

#1 Updated by R.I. Pienaar about 2 years ago

This is unfortunately a fair bit more to do than just the base class – security plugin, clients, the message class and all over the show including code written by users is based on the assumption of symbols.

So the better approach might be to create a translator that will take a message like:

{"data" => {...},
 "sender" => "foo"}

and turn it into symbol equivalents, the replies should be turned into strings and the same translation has to happen in the client.

This way we do not need to do massive surgery to all secuirty plugins, message object and all user code but still be able to work in a JSON compatible way.

Not perfect but its one step nearer, performance of converting from strings to symbol based objects need to be tested as the client is becoming quite performance sensitive

#2 Updated by R.I. Pienaar about 2 years ago

  • Target version changed from 1.3.x to 2.1.x

Also available in: Atom PDF